about_popup: Add current terminal size to Detected Environment section#1624
Open
kevinraj23 wants to merge 2 commits intozulip:mainfrom
Open
about_popup: Add current terminal size to Detected Environment section#1624kevinraj23 wants to merge 2 commits intozulip:mainfrom
kevinraj23 wants to merge 2 commits intozulip:mainfrom
Conversation
kevinraj23
force-pushed
the
add-terminal-size-about-popup
branch
2 times, most recently
from
f95a04d to
6541134
Compare
zulipbot
added
size: S
kevinraj23
force-pushed
the
add-terminal-size-about-popup
branch
from
6541134 to
faa0629
Compare
kevinraj23
force-pushed
the
add-terminal-size-about-popup
branch
from
faa0629 to
8979a5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the current terminal window size to the "Detected Environment"
section of the About popup.
The terminal dimensions are obtained using
self.loop.screen.get_cols_rows()incore.pyand displayed as"{cols} x {rows}" (for example "80 x 24").
How was this tested?
tests/ui_tools/test_popups.pyFixes #1536