Skip to content

Add custom attribute support to the article spider.#109

Open
wRAR wants to merge 3 commits into
mainfrom
article-custom-attrs
Open

Add custom attribute support to the article spider.#109
wRAR wants to merge 3 commits into
mainfrom
article-custom-attrs

Conversation

@wRAR

@wRAR wRAR commented Dec 24, 2024

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Dec 24, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.93%. Comparing base (5a930c7) to head (dc11983).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
zyte_spider_templates/spiders/article.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files          26       26           
  Lines        2609     2610    +1     
=======================================
+ Hits         2503     2504    +1     
  Misses        106      106           
Files with missing lines Coverage Δ
zyte_spider_templates/spiders/article.py 85.97% <83.33%> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmike kmike left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but we should have more tests for this feature before merging & releasing it.

@Gallaecio

Copy link
Copy Markdown
Contributor

Would something basic in line with test_crawl from https://github.com/zytedata/zyte-spider-templates/pull/117/files do the job, or are you thinking of something more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants