Conversation
|
@atteggiani The config docs for ESM1.6 fail to deploy with the preview. Does it need all the PR previews to work in order to deploy? I'm happy to go and fix PR 252, just making sure that should solve the problem before investing time. |
Yes it needs all PR previews to work, unfortunately. Then you would need to re-trigger this PR. You cannot simply retrigger the build manually, so you'll have to add a new commit or amend (no edits) and force push the latest one. |
|
Thanks @ccarouge, fwiw, you might find some of this material helpful: |
Sure thing, @anton-seaice might be a helpful person to canvas too. |
aidanheerdegen
left a comment
There was a problem hiding this comment.
A couple of comments, but otherwise seems good, thanks.
|
@anton-seaice Could you review this, please? I will be away so if you can review for 2nd Feb that would be great. |
anton-seaice
left a comment
There was a problem hiding this comment.
Sorry a bit of a chaotic review, I can have another look as needed
|
Thanks for the review @anton-seaice . I've replied to a few comments and I have a modified version of the text for review. |
anton-seaice
left a comment
There was a problem hiding this comment.
Looks - good . Some minor refinements from me
|
@anton-seaice I've updated these build instructions for ESM1.6. Do you mind if I rebase so I can sign commits that aren't signed? It will break the review stuff so I prefer to ask before going ahead. Another question: do we want to wait for the release of ESM1.6 to push this live or does it not matter? A few things here will only be accessible or possible for users after a release. |
|
No concerns about either. I think we wont advertise the docs until we advertise the release, so its fine to update the docs |
Added information on required repositories and building methods for ACCESS-ESM1.6.
…higher up in mkdocs.yml Got tired of having to scroll down or search for the nav entry when it's the bit we modify the most.
Consistency makes linking between pages easier.
1e477c3 to
224df5a
Compare
|
@anton-seaice One last one! I've rebased the changes to sign off everything, I've checked all the links and re-read the pages after the rebase to check the text looked correct. |
1. Summary:
Added documentation about the building and deployment process for ACCESS-ESM1.6
2. Issues Addressed:
3. Dependencies (e.g. on payu, or model)
This change requires changes to (note pull request(s) where relevant):
4. Ad-hoc Testing
What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?
Documentation only. No testing done. Relying on build preview in PR to correct formatting.
5. CI Testing
!test reprohas been run6. Reproducibility
Is this reproducible with the previous commit? (If not, why not?)
!test repro commithas been run.8. Manifests
Have you changed the executable, the input files and/or the restart files?
If yes, have you updated the manifests?
To update the manifests, run payu setup (in a cloned copy of your feature branch) with reproducibility tests turned off:
Then commit the newly created manifest files (under manifests/) only to the branch for this PR.
7. Documentation
Is the documentation updated?
9. Merge Strategy