Skip to content

Add test-specific repro test markers#137

Merged
dougiesquire merged 2 commits intomainfrom
136-repro-test-markers
Mar 18, 2025
Merged

Add test-specific repro test markers#137
dougiesquire merged 2 commits intomainfrom
136-repro-test-markers

Conversation

@dougiesquire
Copy link
Copy Markdown
Collaborator

This PR adds some test-specific markers to the reproducibility tests to allow finer-grain control over which repro tests are run.

Closes #136

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (4c4de2d) to head (0e96a1e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   75.18%   75.40%   +0.21%     
==========================================
  Files          18       18              
  Lines         927      935       +8     
==========================================
+ Hits          697      705       +8     
  Misses        230      230              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/model_config_tests/test_bit_reproducibility.py
Copy link
Copy Markdown
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dougiesquire, looks good to me

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

Because we've now renamed markers, I'll need to update config repos that are configured to use model-config-tests main as soon as this is merged.

It's probably also worth tagging another release, so we don't end up with a horrible mix of markers in the ci.json - e.g. https://github.com/ACCESS-NRI/access-om3-configs/blob/main/config/ci.json

@jo-basevi
Copy link
Copy Markdown
Contributor

Good point, I agree that a new release would be good - it's probably time to actually start incrementing the major version now that old markers wouldn't work..

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

Okay so I'll tag v0.1.0 once this is merged? I'm going to get the PRs to the config repos ready to go to minimize the period that things don't work.

Copy link
Copy Markdown
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional repro test markers

3 participants