Refactor MDL graph for OpenPBR to avoid layered mixes#2215
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Sep 2, 2025
Conversation
ld-kerley
reviewed
Feb 7, 2025
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Feb 12, 2025
…ring for compatibility with MDL
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Feb 12, 2025
…ring for compatibility with MDL
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Feb 28, 2025
…ring for compatibility with MDL
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Mar 4, 2025
…ring for compatibility with MDL
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Mar 11, 2025
…ring for compatibility with MDL
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Apr 22, 2025
…ring for compatibility with MDL
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Jun 19, 2025
…ring for compatibility with MDL
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Jun 26, 2025
…ring for compatibility with MDL
krohmerNV
force-pushed
the
krohmer/open_pbr_rewrite_thin_film_layering
branch
from
ec1e35b to
dc3fbee
Compare
krohmerNV
changed the title
krohmerNV
changed the title
jstone-lucasfilm
approved these changes
Sep 2, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @krohmerNV!
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit c86d69c
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the MDL code generator we currently can't handle layering constructs like this:
layer(mix(bsdf1, bsdf2, weight), bsdf3)so I propose a workaround that should not change the result but uses an alternative implementation:
mix(layer(bsdf1, bsdf3), layer(bsdf2, bsdf3), weight)