Restrict optimized BSDF graphs to hardware targets#2539
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Sep 2, 2025
jstone-lucasfilm:dev_target_graph_optim
Merged
Restrict optimized BSDF graphs to hardware targets#2539jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom jstone-lucasfilm:dev_target_graph_optim
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm:dev_target_graph_optim
Conversation
This changelist restricts the optimized BSDF graphs for Standard Surface, glTF PBR, and OpenPBR Surface to hardware shading targets, falling back to the original unoptimized graphs on other targets. The optimized graphs now live within a `libraries/bxdf/genglsl` folder with a `glsl` target assignment, and the generic graphs in `libraries/bxdf` have been restored to their pre-optimized versions. In the future, we're hoping to move in the direction of automated optimization of shading model graphs, which would allow each renderer to opt in or out of this category of optimization through GenOptions settings.
Member
Author
|
GitHub doesn't let me yet add @krohmerNV as a formal reviewer, so I'm CC'ing him here in the comments. |
Contributor
|
I like that approach. For intermediate solution it's perfect. |
ld-kerley
approved these changes
Sep 2, 2025
Contributor
ld-kerley
left a comment
ld-kerley
left a comment
There was a problem hiding this comment.
looks neat and tidy to me - thanks for putting this together
jstone-lucasfilm
merged commit 50cee47
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist restricts the optimized BSDF graphs for Standard Surface, glTF PBR, and OpenPBR Surface to hardware shading targets, falling back to the original unoptimized graphs on other targets.
The optimized graphs now live within a
libraries/bxdf/genglslfolder with aglsltarget assignment, and the generic graphs inlibraries/bxdfhave been restored to their pre-optimized versions.In the future, we're hoping to move in the direction of automated optimization of shading model graphs, which would allow each renderer to opt in or out of this category of optimization through GenOptions settings.