explicitly clamp subsurface_color to 0->1 range (#270)#271
Closed
BrianSharpe wants to merge 0 commit intoAcademySoftwareFoundation:dev_1.2from
Closed
explicitly clamp subsurface_color to 0->1 range (#270)#271BrianSharpe wants to merge 0 commit intoAcademySoftwareFoundation:dev_1.2from
BrianSharpe wants to merge 0 commit intoAcademySoftwareFoundation:dev_1.2from
Conversation
Contributor
|
Just to note, we should also add language to the spec making it clear that this clamping has to be done by the shader. (In this case, and all other relevant cases). |
2271cc3 to
34b2b22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenPBR spec says that subsurface_color should be in a strict 0->1 range, but the current nodegraph only clamps it to being above zero (ie, allowing values above 1). This creates a difference in look depending if a renderer allows for albedo to go above 1 or not.
This issue has come up with the (newly released) OpenPBR Shader Playground scene, where the paper surface that the airplane sits on sets the subsurface_color input to a ~3.0->4.0 range (wire input).
Better to explicitly clamp the subsurface_color to its intended 0->1 range, which will preserve look across renderers, regardless of what value is fed into it.