Lazy import progress_bar#812
Merged
Merged
Conversation
jph00
reviewed
May 9, 2026
| # %% ../nbs/03a_parallel.ipynb #f5327cb3 | ||
| try: from fastprogress import progress_bar | ||
| except: progress_bar = None | ||
| def import_progress_bar(): |
Contributor
There was a problem hiding this comment.
FYI I don't think this is worth having a function for - it replaces 2 simple lines of code used in 2 places, with 4 less-simple lines of code in the function plus 2 lines to call it! :)
Contributor
|
Thanks! Merging now - but follow up with a PR if you have a chance to remove the function. Or at least make it private. |
jph00
added a commit
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of projects use
from fastcore.utils import *to get the basic utilities, currently there is a huge bottleneck stemming fromfasthtml->fastprogress->fastcore.parallel. This PR makesprogress_bara lazy import. Python shell scripts such as shell sage will benefit highly from this.