Skip to content

follow up #812#817

Merged
jph00 merged 1 commit into
mainfrom
812-follow-up
May 13, 2026
Merged

follow up #812#817
jph00 merged 1 commit into
mainfrom
812-follow-up

Conversation

@KeremTurgutlu
Copy link
Copy Markdown
Contributor

@KeremTurgutlu KeremTurgutlu requested a review from jph00 May 11, 2026 09:48
@jph00 jph00 closed this May 12, 2026
@jph00 jph00 reopened this May 12, 2026
@jph00
Copy link
Copy Markdown
Contributor

jph00 commented May 13, 2026

I don't understand why this CI is failing. I'll try merging it anyway and see what happens.

@jph00 jph00 merged commit 464a16c into main May 13, 2026
0 of 21 checks passed
@jph00
Copy link
Copy Markdown
Contributor

jph00 commented May 13, 2026

Ah @KeremTurgutlu this had a logic error:

    try: from fastprogress import progress_bar
    except ImportError: return None

You can't return None there - should be progress_bar=None. I've actually removed this try/except now anyway.

@KeremTurgutlu
Copy link
Copy Markdown
Contributor Author

Ah @KeremTurgutlu this had a logic error:

    try: from fastprogress import progress_bar
    except ImportError: return None

You can't return None there - should be progress_bar=None. I've actually removed this try/except now anyway.

Right! Sorry about that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants