control: add guard rails in flight control paths#32820
Draft
vlordier wants to merge 1 commit intoArduPilot:masterfrom
Draft
control: add guard rails in flight control paths#32820vlordier wants to merge 1 commit intoArduPilot:masterfrom
vlordier wants to merge 1 commit intoArduPilot:masterfrom
Conversation
IamPete1
reviewed
Apr 18, 2026
Comment on lines
+449
to
+454
| // NaN or Inf in the actuator value (from upstream thrust/mixing | ||
| // calculations) would produce an undefined int16_t cast. Clamp to | ||
| // the safe minimum so the motor outputs a known-safe value. | ||
| if (!isfinite(actuator)) { | ||
| actuator = 0.0f; | ||
| } |
Member
There was a problem hiding this comment.
If you have evidence that this can actually happen we should fix that not try and deal with it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft isolates a set of control-path robustness changes from the larger hardening branch.
Summary:
Why:
Validation: