AP_ONVIF: tighten string handling#32824
Draft
vlordier wants to merge 1 commit intoArduPilot:masterfrom
Draft
Conversation
peterbarker
requested changes
Apr 18, 2026
Comment on lines
+52
to
+57
| // Initialise length trackers so the first call to start() performs | ||
| // correct comparison and allocation. | ||
| username_len = 0; | ||
| password_len = 0; | ||
| hostname_len = 0; | ||
| profile_token_size = 0; |
Contributor
There was a problem hiding this comment.
This is garbage.
Please re-do your static analysis taking into account our assumptions about zeroed memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft isolates the AP_ONVIF string-handling cleanup from the larger hardening branch.
Summary:
Why:
Validation: