AP_Scheduler: guard overrun reporting#32825
Draft
vlordier wants to merge 1 commit intoArduPilot:masterfrom
Draft
AP_Scheduler: guard overrun reporting#32825vlordier wants to merge 1 commit intoArduPilot:masterfrom
vlordier wants to merge 1 commit intoArduPilot:masterfrom
Conversation
peterbarker
requested changes
Apr 18, 2026
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
This is implicitly zero.
You have just wasted hours of review time because your automated tools do not understand the project you are trying to work with.
Comment on lines
-283
to
+292
| // the event overran! | ||
| debug(3, "Scheduler overrun task[%u-%s] (%u/%u)\n", | ||
| (unsigned)i, | ||
| task.name, | ||
| (unsigned)time_taken, | ||
| (unsigned)_task_time_allowed); | ||
| #if !APM_BUILD_TYPE(APM_BUILD_iofirmware) | ||
| // Log the overrun via INTERNAL_ERROR which is non-blocking, | ||
| // rather than debug() which calls hal.console->printf() and | ||
| // can itself cause a recursive scheduler overrun. | ||
| INTERNAL_ERROR(AP_InternalError::error_t::flow_of_control); | ||
| #endif |
Contributor
There was a problem hiding this comment.
This is a terrible patch, breaking the utility of thedebug statement - which is only used seldomly and by developers tracing issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft isolates the AP_Scheduler overrun-reporting guard changes from the larger hardening branch.
Summary:
Why:
Validation: