Tools: break callisto SITL config to a common method

[Ryanf55]

Summary

• Reduces code duplication of SITL setup for Callisto in the autotest suite

Classification & Testing (check all that apply and add your own)

• Checked by a human programmer
• Non-functional change
• No-binary change
• Infrastructure change (e.g. unit tests, helper scripts)
• Automated test(s) verify changes (e.g. unit test, autotest)
• Tested manually, description below (e.g. SITL)
• Tested on hardware
• Logs attached
• Logs available on request

./Tools/autotest/autotest.py  test.CopterTests2b.PeriphMultiUARTTunnel test.CopterTests1c.BaroWindCorrection test.CopterTests2b.LUAConfigProfile test.CopterTests1c.BaroWindCorrection

Description

Pull out the args needed for callisto into a function that returns kwargs.
You can then use the ** operator to unpack the kwargs nicely.

[hunt0r]

Hurray DRY code!

Opinion: Dicts are most appropriate when the structure of their information is not known in advance. In cases like this one, it's less convenient, but slightly stronger, to use a more structured alternative (e.g. namedtuple, dataclass).

I'm happy to say more if anyone is interested... but it's a minor improvement and definitely not something I'd block over. This is great as-is.

[Ryanf55]

Hurray DRY code!

Opinion: Dicts are most appropriate when the structure of their information is not known in advance. In cases like this one, it's less convenient, but slightly stronger, to use a more structured alternative (e.g. namedtuple, dataclass).

I'm happy to say more if anyone is interested... but it's a minor improvement and definitely not something I'd block over. This is great as-is.

I like named tuples. I'm actually the only person to use that object in the entire Tools folder.

I don't know if that would be allowed in autotest.
Open to maintainer's options, or happy to bump usage of NamedTuple replacing known dictionary contents to another follow up! I was hoping for a quick merge on this :)

[peterbarker]

Better swipe this one too - but add a comment that we do wipe the parameters....