fix: fixed crash in Node 22+ by using Buffer instead of {} with EnumDisplaySettingsA#17
Merged
teo-nikolov merged 2 commits intomainfrom Apr 24, 2025
Merged
fix: fixed crash in Node 22+ by using Buffer instead of {} with EnumDisplaySettingsA#17teo-nikolov merged 2 commits intomainfrom
teo-nikolov merged 2 commits intomainfrom
Conversation
n1xan
approved these changes
Apr 24, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
## [1.0.1](v1.0.0...v1.0.1) (2025-04-25) ### Bug Fixes * fixed crash in Node 22+ by using Buffer instead of {} with EnumDisplaySettingsA ([#17](#17)) ([08e4907](08e4907)) * set shouldCloseApp's default value to true ([#18](#18)) ([28dc1d4](28dc1d4)) ### Code Refactoring * remove unnecessary debug logging for name locator ([#19](#19)) ([ad50be9](ad50be9))
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes a crash that occurs in Node.js 22+ when calling the Windows API function
EnumDisplaySettingsAviakoffiwith an empty object ({}). In previous Node versions, passing an object that gets populated with fields worked fine, but starting from Node 22, this behavior causes a native crash. This change replaces the object with aBuffer, which acts as a workaround for changes in Node 22+ and prevents the native crash.Types of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...