"Open settings" button in the Camera permission rationale dialog#445
"Open settings" button in the Camera permission rationale dialog#445AdamGrzybkowski merged 3 commits intotrunkfrom
Conversation
AdamGrzybkowski
added
the
[Feature] Gravatar-Quickeditor
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
hamorillo
left a comment
hamorillo
left a comment
There was a problem hiding this comment.
Looks good to me! I left some comments about the removed ./idea files.
I couldn't find a way to launch the permission settings directly
Same here. I couldn't find anything, so I think that works. I'll pay attention to other apps and see if any can navigate directly to the permissions screen.
🚀
| @@ -1,44 +0,0 @@ | |||
| <component name="InspectionProjectProfileManager"> | |||
There was a problem hiding this comment.
🤔 I have some doubt about removing this file based on this
There was a problem hiding this comment.
I know that I didn't make any changes to our project config that should be shared, yet those files were modified. If this is some automated stuff by AS, I see no reason to share it. I haven't dug deep into it though...
| @@ -1,6 +0,0 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
🤔 I have some doubt about removing this file based on this however taking a look at gitignore.io they would exclude it.
AdamGrzybkowski
force-pushed
the
adam/422_permision_rationale
branch
from
62dc639 to
77f091c
Compare
3 participants
Closes #422
Description
The camera permission rationale dialog lacked the option to open the App settings directly. This PR changes that.
Unfortunately, I couldn't find a way to launch the permission settings directly.
open_settings.mp4
Testing Steps
open settings