fix issues in todo: anonymous array model import and sample mock value for credential#2342
Merged
qiaozha merged 10 commits intoAzure:mainfrom Mar 13, 2024
Merged
Conversation
qiaozha
changed the title
MaryGao
reviewed
Mar 12, 2024
MaryGao
approved these changes
Mar 12, 2024
Member
MaryGao
left a comment
MaryGao
left a comment
There was a problem hiding this comment.
LGTM and just small comments.
qiaozha
commented
Mar 12, 2024
| } else { | ||
| clientParams.push({ | ||
| name: "credential", | ||
| assignment: `const credential = {getToken: () => Promise.resolve({ token: "{Your token}", expiresOnTimestamp: 0 })};` |
Member
Author
There was a problem hiding this comment.
@joheredi I wonder if you have any concerns for this part for generating the mock value for token credential as we don't have @azure/identity in non-branded scope.
qiaozha
commented
Mar 12, 2024
| ) { | ||
| clientParams.push({ | ||
| name: "credential", | ||
| assignment: `const credential = { key: "{Your API key}"};` |
Member
Author
There was a problem hiding this comment.
also for the KeyCredential mock value here.
Member
Author
|
I will merge it for now, @joheredi let me know if you have any concerns. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2326
fixes #2330