fix issues in todo: anonymous array model import and sample mock value for credential #2342
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,9 +148,6 @@ function transformSpecialLetterToSpace(str: string) { | |
| .replace("'s ", " "); | ||
| } | ||
|
|
||
| function enrichImportedString( | ||
| sampleGroup: RLCSampleGroup, | ||
| importedDict: Record<string, Set<string>>, | ||
|
|
@@ -209,11 +206,17 @@ function convertClientLevelParameters( | |
| // Do not include parameters with constant values in the signature, these should go in the options bag | ||
| (p) => p.value === undefined | ||
| ); | ||
| const { | ||
| addCredentials, | ||
| credentialScopes, | ||
| credentialKeyHeaderName, | ||
| customHttpAuthHeaderName, | ||
| flavor | ||
| } = model.options; | ||
| const hasUrlParameter = !!urlParameters, | ||
| hasCredentials = | ||
| addCredentials && | ||
| (credentialScopes || credentialKeyHeaderName || customHttpAuthHeaderName); | ||
|
|
||
| if (hasUrlParameter) { | ||
| // convert the host parameters in url | ||
|
|
@@ -237,7 +240,11 @@ function convertClientLevelParameters( | |
| } | ||
| if (hasCredentials) { | ||
| // Currently only support token credential | ||
| const apiKeyCredentialPackage = | ||
| flavor === "azure" ? "@azure/core-auth" : "@typespec/ts-http-runtime"; | ||
| const tokenCredentialPackage = | ||
| flavor === "azure" ? "@azure/identity" : "@typespec/ts-http-runtime"; | ||
| if (credentialKeyHeaderName && flavor === "azure") { | ||
| clientParams.push({ | ||
| name: "credential", | ||
| assignment: `const credential = new AzureKeyCredential("{Your API key}");` | ||
|
|
@@ -247,7 +254,15 @@ function convertClientLevelParameters( | |
| "AzureKeyCredential", | ||
| importedDict | ||
| ); | ||
| } else if ( | ||
| (credentialKeyHeaderName && flavor !== "azure") || | ||
| customHttpAuthHeaderName | ||
| ) { | ||
| clientParams.push({ | ||
| name: "credential", | ||
| assignment: `const credential = { key: "{Your API key}"};` | ||
| }); | ||
| } else if (flavor === "azure") { | ||
| clientParams.push({ | ||
| name: "credential", | ||
| assignment: "const credential = new DefaultAzureCredential();" | ||
|
|
@@ -257,6 +272,11 @@ function convertClientLevelParameters( | |
| "DefaultAzureCredential", | ||
| importedDict | ||
| ); | ||
| } else { | ||
| clientParams.push({ | ||
| name: "credential", | ||
| assignment: `const credential = {getToken: () => Promise.resolve({ token: "{Your token}", expiresOnTimestamp: 0 })};` | ||
|
Member
Author
There was a problem hiding this comment. @joheredi I wonder if you have any concerns for this part for generating the mock value for token credential as we don't have |
||
| }); | ||
| } | ||
| } | ||
| return clientParams; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed under the MIT license. | ||
|
|
||
| import createTodoClient from "@notabrand/todo-non-branded"; | ||
| import * as dotenv from "dotenv"; | ||
|
|
||
| dotenv.config(); | ||
|
|
||
| /** | ||
| * This sample demonstrates how to call operation CreateUrlAttachment | ||
| * | ||
| * @summary call operation CreateUrlAttachment | ||
| */ | ||
| async function todoItemsAttachmentsCreateUrlAttachmentSample() { | ||
| const endpoint = "{Your endpoint}"; | ||
| const credential = { key: "{Your API key}" }; | ||
| const client = createTodoClient(endpoint, credential); | ||
| const itemId = 123; | ||
| const result = await client | ||
| .path("/items/{itemId}/attachments", itemId) | ||
| .post({ | ||
| body: { | ||
| contents: { description: "{Your description}", url: "{Your url}" }, | ||
| }, | ||
| contentType: "application/json", | ||
| }); | ||
| console.log(result); | ||
| } | ||
|
|
||
| async function main() { | ||
| todoItemsAttachmentsCreateUrlAttachmentSample(); | ||
| } | ||
|
|
||
| main().catch(console.error); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Licensed under the MIT license. | ||
|
|
||
| import createTodoClient from "@notabrand/todo-non-branded"; | ||
| import * as dotenv from "dotenv"; | ||
|
|
||
| dotenv.config(); | ||
|
|
||
| /** | ||
| * This sample demonstrates how to call operation List | ||
| * | ||
| * @summary call operation List | ||
| */ | ||
| async function todoItemsAttachmentsListSample() { | ||
| const endpoint = "{Your endpoint}"; | ||
| const credential = { key: "{Your API key}" }; | ||
| const client = createTodoClient(endpoint, credential); | ||
| const itemId = 123; | ||
| const result = await client.path("/items/{itemId}/attachments", itemId).get(); | ||
| console.log(result); | ||
| } | ||
|
|
||
| async function main() { | ||
| todoItemsAttachmentsListSample(); | ||
| } | ||
|
|
||
| main().catch(console.error); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Licensed under the MIT license. | ||
|
|
||
| import createTodoClient from "@notabrand/todo-non-branded"; | ||
| import * as dotenv from "dotenv"; | ||
|
|
||
| dotenv.config(); | ||
|
|
||
| /** | ||
| * This sample demonstrates how to call operation CreateJson | ||
| * | ||
| * @summary call operation CreateJson | ||
| */ | ||
| async function todoItemsCreateJsonSample() { | ||
| const endpoint = "{Your endpoint}"; | ||
| const credential = { key: "{Your API key}" }; | ||
| const client = createTodoClient(endpoint, credential); | ||
| const result = await client | ||
| .path("/items") | ||
| .post({ | ||
| body: { | ||
| item: { | ||
| id: 123, | ||
| title: "{Your title}", | ||
| ownedBy: 123, | ||
| description: "{Your description}", | ||
| status: "NotStarted", | ||
| labels: ["{Your labels}"], | ||
| }, | ||
| attachments: [{ description: "{Your description}", url: "{Your url}" }], | ||
| }, | ||
| contentType: "application/json", | ||
| }); | ||
| console.log(result); | ||
| } | ||
|
|
||
| async function main() { | ||
| todoItemsCreateJsonSample(); | ||
| } | ||
|
|
||
| main().catch(console.error); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Licensed under the MIT license. | ||
|
|
||
| import createTodoClient from "@notabrand/todo-non-branded"; | ||
| import * as dotenv from "dotenv"; | ||
|
|
||
| dotenv.config(); | ||
|
|
||
| /** | ||
| * This sample demonstrates how to call operation Delete | ||
| * | ||
| * @summary call operation Delete | ||
| */ | ||
| async function todoItemsDeleteSample() { | ||
| const endpoint = "{Your endpoint}"; | ||
| const credential = { key: "{Your API key}" }; | ||
| const client = createTodoClient(endpoint, credential); | ||
| const id = 123; | ||
| const result = await client.path("/items/{id}", id).delete(); | ||
| console.log(result); | ||
| } | ||
|
|
||
| async function main() { | ||
| todoItemsDeleteSample(); | ||
| } | ||
|
|
||
| main().catch(console.error); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for the KeyCredential mock value here.