Switch to use vendored version for rimraf, mkdirp, and uglify-js in JS repo#2886
Switch to use vendored version for rimraf, mkdirp, and uglify-js in JS repo#2886jeremymeng merged 8 commits intoAzure:mainfrom
Conversation
Similar work has been merged in JS Rep: Azure/azure-sdk-for-js@59bb080
jeremymeng
requested review from
MaryGao,
joheredi,
qiaozha and
sarangan12
as code owners
MaryGao
left a comment
MaryGao
left a comment
There was a problem hiding this comment.
Need applying the same change for RLC and Modular.
and remove "audit" script as it's been removed in Azure JS repo
|
I updated the PR to vendor |
jeremymeng
changed the title
| "integration-test:node": "echo skipped", | ||
| "integration-test:browser": "echo skipped" | ||
| "integration-test:browser": "echo skipped", | ||
| "update-snippets": "echo skipped" |
There was a problem hiding this comment.
May I know what is the purpose of this script?
There was a problem hiding this comment.
This is to extract snippets used in the README.md from a test file so that we don't have to copypaste them manually to check
There was a problem hiding this comment.
Here's the dev-tool command that some packages in our JS repo already use: https://github.com/Azure/azure-sdk-for-js/blob/0cb51b47f1aa5c0b6273bfdeb3cff4cc41460ff2/common/tools/dev-tool/src/commands/run/update-snippets.ts#L17
There was a problem hiding this comment.
@jeremymeng I notice update-snippets is always skipped, do we have any document on when and how to use this script?
There was a problem hiding this comment.
@MaryGao ideally we would have document the command in dev-tool's readme. Not sure about current status. The PR to add this command also has information: Azure/azure-sdk-for-js#31143
MaryGao
left a comment
MaryGao
left a comment
There was a problem hiding this comment.
LGTM and just one comment to confirm.
4 participants
Similar work has been merged in Azure JS Rep: Azure/azure-sdk-for-js@59bb080, Azure/azure-sdk-for-js@980f3cbb89c
audit script has been removed in Azure JS repo: Azure/azure-sdk-for-js@1cae9db8e18
update-snippets script has been added in Azure JS repo: Azure/azure-sdk-for-js@61c8b9aae4f