improve generate-metadata#3317
Merged
qiaozha merged 9 commits intoAzure:mainfrom Jun 30, 2025
Merged
Conversation
qiaozha
approved these changes
Jun 24, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MaryGao
approved these changes
Jun 25, 2025
This reverts commit 5226fec.
maorleger
reviewed
Aug 19, 2025
| const shouldGenerateMetadata = | ||
| option.generateMetadata === true || | ||
| (option.generateMetadata === undefined && !hasPackageFile); | ||
| option.generateMetadata === true || !hasPackageFile; |
Member
There was a problem hiding this comment.
I think this broke the scenario where a user explicitly passes false to generate-metadata which should be honored. Keyvault is a prime example of this https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/keyvault/keyvault-admin/package.json#L45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3306