Skip to content

improve generate-metadata #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiaozha merged 9 commits into from
Jun 30, 2025
Merged

improve generate-metadata #3317

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dbcac94
improve generate-metadata
kazrael2119 Jun 23, 2025
4fb037b
Merge branch 'main' into improve-generate-metadata
kazrael2119 Jun 24, 2025
e40c307
Update index.ts
kazrael2119 Jun 24, 2025
6dbb721
Merge branch 'improve-generate-metadata' of https://github.com/kazrae…
kazrael2119 Jun 24, 2025
6759f38
Merge branch 'main' into improve-generate-metadata
qiaozha Jun 24, 2025
d2c30ba
Merge branch 'main' into improve-generate-metadata
qiaozha Jun 24, 2025
5226fec
update
kazrael2119 Jun 25, 2025
3c69e32
Revert "update"
kazrael2119 Jun 30, 2025
80b1443
Merge branch 'main' into improve-generate-metadata
kazrael2119 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...t/test/todo_non_branded/generated/typespec-ts/src/api/todoItems/attachments/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ import {
TodoItemsAttachmentsCreateJsonAttachmentOptionalParams,
TodoItemsAttachmentsListOptionalParams,
} from "./options.js";
import { expandUrlTemplate } from "../../../static-helpers/urlTemplate.js";
import {
PagedAsyncIterableIterator,
buildPagedAsyncIterator,
} from "../../../static-helpers/pagingHelpers.js";
import { expandUrlTemplate } from "../../../static-helpers/urlTemplate.js";
import {
StreamableMethod,
PathUncheckedResponse,
Expand Down
2 changes: 1 addition & 1 deletion ...typespec-test/test/todo_non_branded/generated/typespec-ts/src/api/todoItems/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ import {
TodoItemsCreateJsonOptionalParams,
TodoItemsListOptionalParams,
} from "./options.js";
import { expandUrlTemplate } from "../../static-helpers/urlTemplate.js";
import {
PagedAsyncIterableIterator,
buildPagedAsyncIterator,
} from "../../static-helpers/pagingHelpers.js";
import { expandUrlTemplate } from "../../static-helpers/urlTemplate.js";
import {
StreamableMethod,
PathUncheckedResponse,
Expand Down
3 changes: 1 addition & 2 deletions packages/typespec-ts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,7 @@ export async function $onEmit(context: EmitContext) {
);
const hasPackageFile = await existsSync(existingPackageFilePath);
const shouldGenerateMetadata =
option.generateMetadata === true ||
(option.generateMetadata === undefined && !hasPackageFile);
option.generateMetadata === true || !hasPackageFile;
Copy link
Copy Markdown
Member

@maorleger maorleger Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke the scenario where a user explicitly passes false to generate-metadata which should be honored. Keyvault is a prime example of this https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/keyvault/keyvault-admin/package.json#L45

const existingTestFolderPath = join(
dpgContext.generationPathDetail?.metadataDir ?? "",
"test"
Expand Down
Loading
⚡