Add missing multipart test coverage for wire names and optional parts#3692
Merged
Add missing multipart test coverage for wire names and optional parts#3692
Conversation
Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve spector case for payload MultiPart
Add missing multipart test coverage for wire names and optional parts
Jan 21, 2026
Member
|
@copilot why delete |
Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Contributor
Author
The files were accidentally deleted during the initial commit when I was exploring the repository structure. They have been restored in commit 331be4c. |
MaryGao
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve spector test cases for payload MultiPart
Completed Tasks:
Summary of Changes:
New Multipart Test Cases Added:
withWireNametest - Validates wire name functionality where TypeSpec property names differ from HTTP form field namesoptionalPartstests (3 scenarios):idfieldprofileImagefieldidandprofileImagefieldsFiles Updated:
packages/typespec-ts/test/integration/multipart.spec.ts(RLC)packages/typespec-ts/test/azureIntegration/multipart.spec.ts(RLC Azure)packages/typespec-ts/test/modularIntegration/payloadMultipart.spec.ts(Modular)packages/typespec-ts/test/azureModularIntegration/payloadMultipart.spec.ts(Modular Azure)Files Restored:
packages/typespec-ts/test/azureModularIntegration/generated/type/enum/extensible/src/index.d.tspackages/typespec-ts/test/azureModularIntegration/generated/type/enum/fixed/src/index.d.tspackages/typespec-ts/test/azureModularIntegration/generated/type/property/additional-properties/src/index.d.tsTest Results:
✅ All new tests passing for both RLC and Modular clients
✅ Code formatted and reviewed
✅ Comments added explaining type assertions
Note on azureArmMethodSubscriptionId:
The azureArmMethodSubscriptionId.spec.ts files already exist and fully match the mockapi.ts expectations, so no updates were needed for those files.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.