Skip to content

[TypeSpec Validation] exclude trailing slash when calculating folder depth#26626

Merged
ckairen merged 4 commits intoAzure:mainfrom
ckairen:al/26549
Dec 6, 2023
Merged

[TypeSpec Validation] exclude trailing slash when calculating folder depth#26626
ckairen merged 4 commits intoAzure:mainfrom
ckairen:al/26549

Conversation

@ckairen
Copy link
Copy Markdown
Contributor

@ckairen ckairen commented Nov 8, 2023

closes #26549

@ckairen ckairen added the Central-EngSys This issue is owned by the Engineering System team. label Nov 8, 2023
@ckairen ckairen self-assigned this Nov 8, 2023
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 8, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 8, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 8, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 8, 2023

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@ckairen ckairen marked this pull request as ready for review November 8, 2023 21:40
Comment thread eng/tools/typespec-validation/src/rules/folder-structure.ts Outdated
Comment thread eng/tools/typespec-validation/src/rules/folder-structure.ts Outdated
Copy link
Copy Markdown
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test

@ckairen
Copy link
Copy Markdown
Contributor Author

ckairen commented Nov 30, 2023

Please add a unit test

This unit test will be built on top of the unit test in this pr #26721

blocked until that pr is merged

@ckairen ckairen merged commit 9971340 into Azure:main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

Development

Successfully merging this pull request may close these issues.

[TypeSpec Validation] Incorrectly includes trailing slash when calculating folder depth

3 participants