Azure OpenAI: TypeSpec updates for 2023-12-01-preview#26737
Merged
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Nov 16, 2023
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
…i-2023-12-01-preview-typespec
…://github.com/Azure/azure-rest-api-specs into user/travisw/aoai-2023-12-01-preview-typespec
* Update spell checking instructions (#26874) Having one custom-words.txt for the entire repo has been causing a number of merging issues so we are trying to move away from it and instead have teams use override in the cspell configuration file directly. * Update readme.python.md (#26894) * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [Cognitive Services - Azure AI Content Safety] Update package print name. (#26911) * Update package print name. * update. * update name. * Added TypeSpec customization support for Java --------- Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: jiezhou_microsoft <94604058+JieZhou000@users.noreply.github.com>
deyaaeldeen
reviewed
Dec 2, 2023
…tions/chat_completions.tsp Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
deyaaeldeen
reviewed
Dec 4, 2023
deyaaeldeen
reviewed
Dec 6, 2023
| type: "function"; | ||
|
|
||
| @doc("The name of the function that should be called.") | ||
| name: "string"; |
Member
There was a problem hiding this comment.
The type should be string and not the literal "string", I think.
Suggested change
| name: "string"; | |
| name: string; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR transfers to TypeSpec the changes made in the
2023-12-01-previewservice API version for Azure OpenAI:https://github.com/Azure/azure-rest-api-specs/tree/main/specification/cognitiveservices/data-plane/AzureOpenAI/inference/preview/2023-12-01-preview