[OpenAI] Removing LROs from the client surface#26898
Merged
trrwilson merged 1 commit intouser/travisw/aoai-2023-12-01-preview-typespecfrom Nov 30, 2023
Merged
Conversation
Member
jpalvarezl
commented
Nov 30, 2023
jpalvarezl
commented
- Hidding LROs. The models are still there for the sake of keeping old swagger files unchanged. Do we want to remove them entirely?
- Some updates to swagger files (just compiled the project)
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
trrwilson
approved these changes
Nov 30, 2023
lmazuel
pushed a commit
that referenced
this pull request
Dec 6, 2023
* baseline: add new label with no changes * reapplication of changes from PR repository * incremental: chat inputs, including tools * incremental, in-progress: chat message rework * incremental: chat completions updated (undoc'd/unverified) * incremental: provisional completeness for chat * Incremental: RAI updates * RAI, data-plane, tsp compilation fixes * minor updates after starting .NET integration * small fix to structured text items for vision * small but important function fix * trial and error: OYD apiKey->key * minor edit * java emitter config merge * some PR feedback + tool_calls role fix * small but important: url is optional in protected_material_code * add missing layer to image_url * Add speculative finish_details for gpt-4-vision-preview * Reorging files for extensions * Using generics * Removed generics approach * Fixed various typos and added docs * Removed super class parameters * Removed LRO entries in client.tsp, since they are removed from spec anyway * WIP * removed LRO related definitions * Added @client to hide the LRO op * Moved visibility modifiers to their own source file * Annotated Key as removed * Restored LRO as private methods * PR feedback * Hid LROs (#26898) * format, recompile, backport optional filename for whisper * PR feedback: naming/docs updates * Added TypeSpec customization support for Java (#26916) * Update spell checking instructions (#26874) Having one custom-words.txt for the entire repo has been causing a number of merging issues so we are trying to move away from it and instead have teams use override in the cspell configuration file directly. * Update readme.python.md (#26894) * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [Cognitive Services - Azure AI Content Safety] Update package print name. (#26911) * Update package print name. * update. * update name. * Added TypeSpec customization support for Java --------- Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: jiezhou_microsoft <94604058+JieZhou000@users.noreply.github.com> * Renamed customization class (#26919) * Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_completions.tsp Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * recompile after accepted/committed feedback fix * PR feedback: non-optional content_filter_results on prompt model * very minor change: one file fix via npx prettier * missing second half of prettier fix: copied file to data-plane --------- Co-authored-by: Jose Alvarez <jp.alvarezl@gmail.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: jiezhou_microsoft <94604058+JieZhou000@users.noreply.github.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.