Add "MakeBackupsImmutable" and "BackupStorageAccessTier" properties to LTRPolicies swagger file by CelinaJiangJXY · Pull Request #26854 · Azure/azure-rest-api-specs

CelinaJiangJXY · 2023-11-28T00:48:20Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-11-28T00:48:23Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-11-28T00:48:24Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
LongTermRetentionBackups.json	2023-05-01-preview(9acb9f0)	2023-05-01-preview(main)
LongTermRetentionPolicies.json	2023-05-01-preview(9acb9f0)	2023-05-01-preview(main)

Rule	Message
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'BaseLongTermRetentionPolicyProperties' removed or renamed? New: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L197:3 Old: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L188:3
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L207:9 Old: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L221:9
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'makeBackupsImmutable' in response that was not found in the old version. New: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L236:7 Old: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L192:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'backupStorageAccessTier' in response that was not found in the old version. New: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L236:7 Old: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionPolicies.json#L192:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-preview-2023-05	package-preview-2023-05(9acb9f0)	package-preview-2023-05(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L19
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L88
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L88
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L164
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L164
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionDatabaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L164
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L247
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L247
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionDatabaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L247
`❌` ResourceNameRestriction	The resource name parameter 'backupName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L247
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L310
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L362
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L374
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L374
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionDatabaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L374
`❌` ResourceNameRestriction	The resource name parameter 'backupName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L374
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L434
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L446
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L446
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionDatabaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L446
`❌` ResourceNameRestriction	The resource name parameter 'backupName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L446
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L511
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L523
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L523
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionDatabaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L523
`❌` ResourceNameRestriction	The resource name parameter 'backupName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L523
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L588
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L600
`❌` ResourceNameRestriction	The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L672
`❌` ResourceNameRestriction	The resource name parameter 'longTermRetentionServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2023-05-01-preview/LongTermRetentionBackups.json#L672

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-28T00:48:25Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/sql/armsql - Approved - 2.0.0-beta.4

+	Type of `LongTermRetentionPolicy.Properties` has been changed from `*BaseLongTermRetentionPolicyProperties` to `*LongTermRetentionPolicyProperties`

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 92278bb410f75424890e91c3db0b1b1f68d1d654. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.5` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-sql [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.begin_change_access_tier
info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.begin_change_access_tier_by_resource_group
info	[Changelog]   - Model LongTermRetentionBackup has a new parameter backup_storage_access_tier
info	[Changelog]   - Model LongTermRetentionBackup has a new parameter is_backup_immutable
info	[Changelog]   - Model LongTermRetentionPolicy has a new parameter backup_storage_access_tier
info	[Changelog]   - Model LongTermRetentionPolicy has a new parameter make_backups_immutable

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 92278bb410f75424890e91c3db0b1b1f68d1d654. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Sql [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.Sql.1.3.0-alpha.20231207.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 92278bb410f75424890e91c3db0b1b1f68d1d654. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-sql-generated [View full logs] [Preview SDK Changes]
- pom.xml

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 92278bb410f75424890e91c3db0b1b1f68d1d654. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/sql/armsql [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `LongTermRetentionPolicy.Properties` has been changed from `*BaseLongTermRetentionPolicyProperties` to `*LongTermRetentionPolicyProperties`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `BackupStorageAccessTier` with values `BackupStorageAccessTierArchive`, `BackupStorageAccessTierHot`
info	[Changelog] - New function `*ClientFactory.NewJobPrivateEndpointsClient() *JobPrivateEndpointsClient`
info	[Changelog] - New function `NewJobPrivateEndpointsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobPrivateEndpointsClient, error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.BeginCreateOrUpdate(context.Context, string, string, string, string, JobPrivateEndpoint, *JobPrivateEndpointsClientBeginCreateOrUpdateOptions) (*runtime.Poller[JobPrivateEndpointsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.BeginDelete(context.Context, string, string, string, string, *JobPrivateEndpointsClientBeginDeleteOptions) (*runtime.Poller[JobPrivateEndpointsClientDeleteResponse], error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.Get(context.Context, string, string, string, string, *JobPrivateEndpointsClientGetOptions) (JobPrivateEndpointsClientGetResponse, error)`
info	[Changelog] - New function `*JobPrivateEndpointsClient.NewListByAgentPager(string, string, string, *JobPrivateEndpointsClientListByAgentOptions) *runtime.Pager[JobPrivateEndpointsClientListByAgentResponse]`
info	[Changelog] - New function `*LongTermRetentionBackupsClient.BeginChangeAccessTier(context.Context, string, string, string, string, ChangeLongTermRetentionBackupAccessTierParameters, *LongTermRetentionBackupsClientBeginChangeAccessTierOptions) (*runtime.Poller[LongTermRetentionBackupsClientChangeAccessTierResponse], error)`
info	[Changelog] - New function `*LongTermRetentionBackupsClient.BeginChangeAccessTierByResourceGroup(context.Context, string, string, string, string, string, ChangeLongTermRetentionBackupAccessTierParameters, *LongTermRetentionBackupsClientBeginChangeAccessTierByResourceGroupOptions) (*runtime.Poller[LongTermRetentionBackupsClientChangeAccessTierByResourceGroupResponse], error)`
info	[Changelog] - New struct `ChangeLongTermRetentionBackupAccessTierParameters`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog] - New struct `JobPrivateEndpoint`
info	[Changelog] - New struct `JobPrivateEndpointListResult`
info	[Changelog] - New struct `JobPrivateEndpointProperties`
info	[Changelog] - New struct `LongTermRetentionPolicyProperties`
info	[Changelog] - New field `DNSZone`, `MaintenanceConfigurationID` in struct `InstancePoolProperties`
info	[Changelog] - New field `Properties`, `SKU` in struct `InstancePoolUpdate`
info	[Changelog] - New field `BackupStorageAccessTier`, `IsBackupImmutable` in struct `LongTermRetentionBackupProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 30 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 92278bb410f75424890e91c3db0b1b1f68d1d654. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-sql [View full logs] [Preview SDK Changes]

azure-arm-sql-10.1.0-beta.3.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group JobPrivateEndpoints
info	[Changelog]   - Added operation FailoverGroups.beginTryPlannedBeforeForcedFailover
info	[Changelog]   - Added operation FailoverGroups.beginTryPlannedBeforeForcedFailoverAndWait
info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTier
info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTierAndWait
info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTierByResourceGroup
info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTierByResourceGroupAndWait
info	[Changelog]   - Added Interface ChangeLongTermRetentionBackupAccessTierParameters
info	[Changelog]   - Added Interface ErrorAdditionalInfo
info	[Changelog]   - Added Interface ErrorDetail
info	[Changelog]   - Added Interface ErrorResponse
info	[Changelog]   - Added Interface FailoverGroupsTryPlannedBeforeForcedFailoverHeaders
info	[Changelog]   - Added Interface FailoverGroupsTryPlannedBeforeForcedFailoverOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpoint
info	[Changelog]   - Added Interface JobPrivateEndpointListResult
info	[Changelog]   - Added Interface JobPrivateEndpointsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsDeleteOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsGetOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsListByAgentNextOptionalParams
info	[Changelog]   - Added Interface JobPrivateEndpointsListByAgentOptionalParams
info	[Changelog]   - Added Interface LongTermRetentionBackupsChangeAccessTierByResourceGroupOptionalParams
info	[Changelog]   - Added Interface LongTermRetentionBackupsChangeAccessTierOptionalParams
info	[Changelog]   - Added Type Alias BackupStorageAccessTier
info	[Changelog]   - Added Type Alias FailoverGroupsTryPlannedBeforeForcedFailoverResponse
info	[Changelog]   - Added Type Alias FreeLimitExhaustionBehavior
info	[Changelog]   - Added Type Alias JobPrivateEndpointsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias JobPrivateEndpointsGetResponse
info	[Changelog]   - Added Type Alias JobPrivateEndpointsListByAgentNextResponse
info	[Changelog]   - Added Type Alias JobPrivateEndpointsListByAgentResponse
info	[Changelog]   - Added Type Alias LongTermRetentionBackupsChangeAccessTierByResourceGroupResponse
info	[Changelog]   - Added Type Alias LongTermRetentionBackupsChangeAccessTierResponse
info	[Changelog]   - Interface Database has a new optional parameter encryptionProtectorAutoRotation
info	[Changelog]   - Interface Database has a new optional parameter freeLimitExhaustionBehavior
info	[Changelog]   - Interface Database has a new optional parameter useFreeLimit
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter encryptionProtectorAutoRotation
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter freeLimitExhaustionBehavior
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter useFreeLimit
info	[Changelog]   - Interface ElasticPool has a new optional parameter availabilityZone
info	[Changelog]   - Interface ElasticPool has a new optional parameter minCapacity
info	[Changelog]   - Interface ElasticPool has a new optional parameter preferredEnclaveType
info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter availabilityZone
info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter minCapacity
info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter preferredEnclaveType
info	[Changelog]   - Interface FailoverGroupReadOnlyEndpoint has a new optional parameter targetServer
info	[Changelog]   - Interface FailoverGroupUpdate has a new optional parameter partnerServers
info	[Changelog]   - Interface InstancePool has a new optional parameter dnsZone
info	[Changelog]   - Interface InstancePool has a new optional parameter maintenanceConfigurationId
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter dnsZone
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter licenseType
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter maintenanceConfigurationId
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter sku
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter subnetId
info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter vCores
info	[Changelog]   - Interface LongTermRetentionBackup has a new optional parameter backupStorageAccessTier
info	[Changelog]   - Interface LongTermRetentionBackup has a new optional parameter isBackupImmutable
info	[Changelog]   - Interface LongTermRetentionPolicy has a new optional parameter backupStorageAccessTier
info	[Changelog]   - Interface LongTermRetentionPolicy has a new optional parameter makeBackupsImmutable
info	[Changelog]   - Interface ManagedDatabase has a new optional parameter isLedgerOn
info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter isLedgerOn
info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
info	[Changelog]   - Interface Server has a new optional parameter isIPv6Enabled
info	[Changelog]   - Interface ServerUpdate has a new optional parameter isIPv6Enabled
info	[Changelog]   - Interface SqlVulnerabilityAssessmentScanRecord has a new optional parameter lastScanTime
info	[Changelog]   - Added Enum KnownBackupStorageAccessTier
info	[Changelog]   - Added Enum KnownFreeLimitExhaustionBehavior

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 92278bb410f75424890e91c3db0b1b1f68d1d654. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.5
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.5>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.5` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️sql [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 92278bb410f75424890e91c3db0b1b1f68d1d654. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.sql.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.sql.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-28T00:48:25Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sql/armsql	https://apiview.dev/Assemblies/Review/cfe8012294274104820f0f705c044e4f
.Net	Azure.ResourceManager.Sql	https://apiview.dev/Assemblies/Review/e678098937a9430bb26335955b89d599
JavaScript	@azure/arm-sql	https://apiview.dev/Assemblies/Review/275aace572a64ddd97759c1f6d9f3681
Swagger	Microsoft.Sql	https://apiview.dev/Assemblies/Review/e4688a920123419784bec23820d6ce15

openapi-workflow-bot · 2023-11-28T00:58:43Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

jeremyfrosti

LGTM

CelinaJiangJXY · 2023-12-08T20:13:00Z

/pr RequestMerge

…o LTRPolicies swagger file (#26854) * added 2 new properties * fix typo and check failures * added missing properties to LTRPolicy

added 2 new properties

c3390d6

CelinaJiangJXY requested review from ericshape, jamestao and jeremyfrosti as code owners November 28, 2023 00:48

openapi-assignment-bot Bot assigned rkmanda Nov 28, 2023

azure-sdk mentioned this pull request Nov 28, 2023

[AutoPR sdk/resourcemanager/sql/armsql] Add "MakeBackupsImmutable" and "BackupStorageAccessTier" properties to LTRPolicies swagger file azure-sdk/azure-sdk-for-go#8293

Closed

openapi-pipeline-app Bot added the CI-BreakingChange-Go label Nov 28, 2023

AzureRestAPISpecReview added ARMChangesRequested ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Nov 28, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 4, 2023

CelinaJiangJXY added 3 commits December 7, 2023 03:04

Merge branch 'main' into dev/cejiang/LongTermRetentionArchiveFix

3e7137f

fix typo and check failures

a20f1c9

added missing properties to LTRPolicy

9acb9f0

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Dec 7, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Dec 8, 2023

jeremyfrosti added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Dec 8, 2023

visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 8, 2023

openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 8, 2023

jeremyfrosti approved these changes Dec 8, 2023

View reviewed changes

microsoft-github-policy-service Bot added the MergeRequested label Dec 8, 2023

visingla-ms approved these changes Dec 8, 2023

View reviewed changes

visingla-ms merged commit 03a5d0b into Azure:main Dec 8, 2023

arifibrahim4 pushed a commit that referenced this pull request Feb 26, 2024

Add "MakeBackupsImmutable" and "BackupStorageAccessTier" properties t…

25afec5

…o LTRPolicies swagger file (#26854) * added 2 new properties * fix typo and check failures * added missing properties to LTRPolicy

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "MakeBackupsImmutable" and "BackupStorageAccessTier" properties to LTRPolicies swagger file#26854

Add "MakeBackupsImmutable" and "BackupStorageAccessTier" properties to LTRPolicies swagger file#26854
visingla-ms merged 4 commits intoAzure:mainfrom
CelinaJiangJXY:dev/cejiang/LongTermRetentionArchiveFix

CelinaJiangJXY commented Nov 28, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Nov 28, 2023

Uh oh!

jeremyfrosti left a comment

Uh oh!

CelinaJiangJXY commented Dec 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

CelinaJiangJXY commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot Bot commented Nov 28, 2023

Uh oh!

jeremyfrosti left a comment

Choose a reason for hiding this comment

Uh oh!

CelinaJiangJXY commented Dec 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CelinaJiangJXY commented Nov 28, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 28, 2023 •

edited

Loading