Skip to content

Add client.tsp for easm which is impacted by client hierarchy change#26980

Merged
tadelesh merged 1 commit intomainfrom
fix_client_hierarchy_breaking
Dec 7, 2023
Merged

Add client.tsp for easm which is impacted by client hierarchy change#26980
tadelesh merged 1 commit intomainfrom
fix_client_hierarchy_breaking

Conversation

@tadelesh
Copy link
Copy Markdown
Member

@tadelesh tadelesh commented Dec 7, 2023

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Dec 7, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Dec 7, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Dec 7, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from 8b805c08d720ce13dda580cd92db9a115da9dba3. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] WARN EBADENGINE Unsupported engine {
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   package: '@azure-tools/typespec-azure-core@0.36.0',
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE Unsupported engine {
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   package: '@azure-tools/typespec-client-generator-core@0.36.1',
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE Unsupported engine {
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   package: '@typespec/compiler@0.50.0',
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE Unsupported engine {
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   package: '@typespec/http@0.50.0',
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE Unsupported engine {
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   package: '@typespec/rest@0.50.0',
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE Unsupported engine {
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   package: '@typespec/versioning@0.50.0',
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm WARN EBADENGINE }
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New major version of npm available! 8.19.4 -> 10.2.5
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.5>
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Run `npm install -g npm@10.2.5` to update!
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 141 | �[0m               �[36;1mGeneratePackage `�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 141 | �[0m               �[36;1mGeneratePackage `�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 141 | �[0m               �[36;1mGeneratePackage `�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.Analytics.Defender.Easm [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-js failed [Detail]
  • Failed [Logs] Generate from 8b805c08d720ce13dda580cd92db9a115da9dba3. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] Error:
    cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for typespec project: "specification/riskiq/Easm":
    cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t @azure-rest/defender-easm-rest
    cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
    cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
    cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t @azure-rest/defender-easm-rest
    cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
    cmderr	[automation_generate.sh] [ERROR]     at Object.execSync (node:child_process:957:15)
    cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/llc/generateRLCInPipeline/generateRLCInPipeline.js:209:29)
    cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
    cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
  • @azure-rest/defender-easm-rest [View full logs]  [Preview SDK Changes]
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 8b805c08d720ce13dda580cd92db9a115da9dba3. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/compiler@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/rest@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/http@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/openapi@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/versioning@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/typespec-azure-core@0.37.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/typespec-client-generator-core@0.37.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm notice
    cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 10.2.5
    cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.5>
    cmderr	[generate.py] npm notice Run `npm install -g npm@10.2.5` to update!
    cmderr	[generate.py] npm notice
  • ️✔️azure-analytics-defender-easm [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Dec 7, 2023

Generated ApiView

Language Package Name ApiView Link
Java azure-analytics-defender-easm There is no API change compared with the previous version
TypeSpec Easm https://apiview.dev/Assemblies/Review/5325081bde3641fb91d7e4d6c00a9c55

@tadelesh tadelesh marked this pull request as ready for review December 7, 2023 05:42
Copy link
Copy Markdown
Member

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If new operation is added in main.tsp, author needs to update client.tsp manually which is not very convenient to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants