tsp, update tsp-location of EASM to point to the commit ID which includes client.tsp#37962
Merged
weidongxu-microsoft merged 4 commits intoAzure:mainfrom Dec 8, 2023
Conversation
Member
Author
|
/azp run java - openai |
Member
Author
|
/azp run java - easm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run java - openai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - easm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
changed the title
Member
Author
|
/azp run java - openai |
Member
Author
|
/azp run java - easm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
requested review from
JimSuplizio,
JonathanGiles,
anuchandy,
benbp,
conniey,
hallipr,
joshfree,
lmolkova,
srnagar and
weshaggard
as code owners
Comment on lines
6
to
14
| "devDependencies": { | ||
| "@typespec/openapi": "0.50.0", | ||
| "@typespec/compiler": "0.50.0", | ||
| "@typespec/versioning": "0.50.0", | ||
| "@typespec/rest": "0.50.0", | ||
| "@typespec/http": "0.50.0", | ||
| "@azure-tools/typespec-azure-core": "0.36.0", | ||
| "@azure-tools/typespec-client-generator-core": "0.36.1" | ||
| } |
Member
Author
There was a problem hiding this comment.
I will revert the change on "devDependencies", if OpenAI is not affected in their new PR #37739
| @@ -1,3 +1,3 @@ | |||
| directory: specification/riskiq/Easm | |||
| commit: f5f584c65071dc0306544a195fbcdff156023040 | |||
| commit: 11dd0dbfb9bec989f3a9a3536ae526407ff17c78 | |||
Member
Author
There was a problem hiding this comment.
This change is required for TCGC behavior change. This commit ID added a client.tsp https://github.com/Azure/azure-rest-api-specs/pull/26980/files
srnagar
approved these changes
Dec 7, 2023
Revert change to emitter-package.json, as in OpenAI latest PR, they no longer need the LRO Azure#37739
Member
Author
|
/azp run java - easm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is behavior change on
@azure-tools/typespec-azure-core0.37.0, that affect codegen LRO logic, which would impact generated code (when typespec-java does not change at all).PS: here is what happens without this pin https://github.com/Azure/azure-sdk-for-java/pull/37961/files (ignore documentintelligence). You can see typespec-java emitter is not changed at all.
Therefore, temporary pin
@azure-tools/typespec-azure-coreto 0.36.0, to avoid affect OpenAI SDK.I will remove this "devDependencies" after I figure out why behavior changed, and mitigated it in next release (aka 0.12.0).
EASM is solved via Azure/azure-rest-api-specs#26980 (for the client hierarchy behavior change). Hence here I update the commit in tsp-location to latest main.