Skip to content

Add DnsConfiguration site property to Microsoft.Web API Specs#27378

Merged
naveedaz merged 6 commits intoAzure:release-web-2023-12-01from
tbhartia:add_dns_config
Mar 14, 2024
Merged

Add DnsConfiguration site property to Microsoft.Web API Specs#27378
naveedaz merged 6 commits intoAzure:release-web-2023-12-01from
tbhartia:add_dns_config

Conversation

@tbhartia
Copy link
Copy Markdown
Contributor

@tbhartia tbhartia commented Jan 15, 2024 •
edited
Loading

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • Adding a new site property to Microsoft.Web API spec

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@tbhartia tbhartia requested a review from naveedaz as a code owner January 15, 2024 07:10
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 15, 2024 •
edited
Loading

PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 15, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️❌Breaking Change(Cross-Version): 17 Errors, 12 Warnings failed [Detail]
compared swaggers (via Oad v0.10.5)] new version base version
CommonDefinitions.json 2023-12-01(0ff7eed) 2023-01-01(main)
WebApps.json 2023-12-01(0ff7eed) 2023-01-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
❌ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L271:11
❌ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1148:11
❌ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1937:11
❌ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2496:11
❌ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2560:11
❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L973:9
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29134:13
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'id' renamed or removed?
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'kind' renamed or removed?
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'type' renamed or removed?
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L227:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L221:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L298:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L282:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1107:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L1090:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1896:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L1869:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2455:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L2418:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2519:7
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L2472:7
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6390:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6333:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L964:9
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29130:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6425:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6368:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6439:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6382:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6515:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6458:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6529:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6472:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15713:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15454:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15748:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15489:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15769:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15510:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15852:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15593:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15873:13
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15614:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L969:5
Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29121:5
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 15, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-java warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️🔄 azure-resource-manager-schemas inProgress [Detail]
️⚠️ azure-powershell warning [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 15, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appservice/armappservice https://apiview.dev/Assemblies/Review/c5375c6f5a4443168e64c981277b8377?revisionId=d8760e3ba13b4009a3b414a50e3cafa8
Java azure-resourcemanager-appservice-generated https://apiview.dev/Assemblies/Review/a2b80e4fbd144844bca0c504ef8c3337?revisionId=1a9dfb9cbc734a839b431d9d7c70c65d
JavaScript @azure/arm-appservice https://apiview.dev/Assemblies/Review/98dbdc8147d7472b9bdff567a8b291bc?revisionId=57caf7945d3843c9932ec7a195770b7b

@tbhartia tbhartia changed the title Add dns config Add DnsConfiguration site property to Microsoft.Web API Specs Jan 15, 2024
@azure-sdk azure-sdk mentioned this pull request Jan 15, 2024
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 15, 2024
This was referenced Jan 15, 2024
Closed
Closed
Closed
Closed
raosuhas
raosuhas reviewed Jan 23, 2024
View reviewed changes
Comment thread specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json Outdated
@openapi-workflow-bot
Copy link
Copy Markdown

openapi-workflow-bot Bot commented Jan 23, 2024

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Feb 26, 2024
@tbhartia tbhartia requested a review from raosuhas March 6, 2024 18:21
@openapi-workflow-bot openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 6, 2024
@TimLovellSmith
Copy link
Copy Markdown
Member

TimLovellSmith commented Mar 6, 2024

Please could you complete due diligence checklist, and confirm that this is a proposal to add a new property in the response to an existing shipped API version that could be considered a breaking change?

@openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 6, 2024
TimLovellSmith
TimLovellSmith approved these changes Mar 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@TimLovellSmith TimLovellSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@naveedaz naveedaz merged commit b2e4a14 into Azure:release-web-2023-12-01 Mar 14, 2024
catalinaperalta pushed a commit that referenced this pull request Apr 20, 2024
@naveedaz @vkarasala
@xingyangli1278 @xingyang-li @crosenblatt @hdmimsft @Francisco-Gamino @vishal1997 @DJagwani @ha0ch1 @tbhartia @amberrenton @jocawtho @kazrael2119 @Alancere
Release web 2023 12 01 (#28268)
a50b142 
* Introduce Microsoft.Web API version 2023-12-01 (#27100)

* Add VnetBackupRestoreEnabled property to the latest API Version (#27175)

* changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317)

Co-authored-by: Xingyang Li <xingyangli@microsoft.com>

* e2e encryption (#27226)

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>

* Adding Vnet-related APIs to Swagger (#27251)

* Add function app config to latest Web API (#27358)

* Add functionAppConfig definition

* Add create or update function app Flex Consumption example

* Add create or update function app Flex Consumption with details example

* Update CommonDefinitions.json to reference the new examples

* Make PUT/PATCH api async for function on aca (#27612)

* Make PUT/PATCH api async for function on aca

* Remove response body

* update examples

* Add headers

---------

Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>

* Add FlexConsumption to the list of supported skus (#27951)

* Add TLS1.3 to valid TLS Versions (#27885)

Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm

* Added Linux SiteContainer APIs (#27942)

* Added Linux SiteContainer APIs

* Resolved validation failures.

* Added SiteContainer and SiteContainerCollection

* Fixed LintDiff errors

* Fixed spellings

* Updated params order.

* Resolving comments.

* Resolving comments.

* Added volumeMounts and envVariables.

* Resolving comments

* Resolving comments

* Removed type and metadata.

* Haochidu/release web 2023 12 01/aseregion hotfix (#28018)

* Update ResourceProvider.json

hot fix

API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification.

* Update ResourceProvider.json

* Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249)

This reverts commit 0765e9d.

* Add DnsConfiguration site property to Microsoft.Web API Specs (#27378)

* Add DnsConfiguration property to WebApps.json

* Add SiteDnsConfig to CommonDefinitions.json

* Updated dnslegacy property description

* Update CommonDefinitions.json

* Undo previous update to CommonDefinitions.json

* Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder

* Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289)

Co-authored-by: Amber Renton <amberrenton@microsoft.com>

* Update create function app examples for Flex Consumption (#28566)

* Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568)

This reverts commit cd214ae.

* Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738)

This reverts commit ec1d84f.

* create sdk-suppression.yaml (#28751)

* create sdk-suppression.yaml

* add azure-sdk-for-go suppression

---------

Co-authored-by: Alancere <804873052@qq.com>

---------

Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com>
Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com>
Co-authored-by: Xingyang Li <xingyangli@microsoft.com>
Co-authored-by: Chris Rosenblatt <rosench13@gmail.com>
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com>
Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com>
Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com>
Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>
Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com>
Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com>
Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com>
Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com>
Co-authored-by: Amber Renton <amberrenton@microsoft.com>
Co-authored-by: jocawtho <jocawtho@microsoft.com>
Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: Alancere <804873052@qq.com>
rkmanda pushed a commit that referenced this pull request Apr 20, 2024
@naveedaz @vkarasala
@xingyangli1278 @xingyang-li @crosenblatt @hdmimsft @Francisco-Gamino @vishal1997 @DJagwani @ha0ch1 @tbhartia @amberrenton @jocawtho @kazrael2119 @Alancere
Release web 2023 12 01 (#28268)
72f52bc 
* Introduce Microsoft.Web API version 2023-12-01 (#27100)

* Add VnetBackupRestoreEnabled property to the latest API Version (#27175)

* changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317)

Co-authored-by: Xingyang Li <xingyangli@microsoft.com>

* e2e encryption (#27226)

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>

* Adding Vnet-related APIs to Swagger (#27251)

* Add function app config to latest Web API (#27358)

* Add functionAppConfig definition

* Add create or update function app Flex Consumption example

* Add create or update function app Flex Consumption with details example

* Update CommonDefinitions.json to reference the new examples

* Make PUT/PATCH api async for function on aca (#27612)

* Make PUT/PATCH api async for function on aca

* Remove response body

* update examples

* Add headers

---------

Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>

* Add FlexConsumption to the list of supported skus (#27951)

* Add TLS1.3 to valid TLS Versions (#27885)

Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm

* Added Linux SiteContainer APIs (#27942)

* Added Linux SiteContainer APIs

* Resolved validation failures.

* Added SiteContainer and SiteContainerCollection

* Fixed LintDiff errors

* Fixed spellings

* Updated params order.

* Resolving comments.

* Resolving comments.

* Added volumeMounts and envVariables.

* Resolving comments

* Resolving comments

* Removed type and metadata.

* Haochidu/release web 2023 12 01/aseregion hotfix (#28018)

* Update ResourceProvider.json

hot fix

API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification.

* Update ResourceProvider.json

* Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249)

This reverts commit 0765e9d.

* Add DnsConfiguration site property to Microsoft.Web API Specs (#27378)

* Add DnsConfiguration property to WebApps.json

* Add SiteDnsConfig to CommonDefinitions.json

* Updated dnslegacy property description

* Update CommonDefinitions.json

* Undo previous update to CommonDefinitions.json

* Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder

* Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289)

Co-authored-by: Amber Renton <amberrenton@microsoft.com>

* Update create function app examples for Flex Consumption (#28566)

* Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568)

This reverts commit cd214ae.

* Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738)

This reverts commit ec1d84f.

* create sdk-suppression.yaml (#28751)

* create sdk-suppression.yaml

* add azure-sdk-for-go suppression

---------

Co-authored-by: Alancere <804873052@qq.com>

---------

Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com>
Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com>
Co-authored-by: Xingyang Li <xingyangli@microsoft.com>
Co-authored-by: Chris Rosenblatt <rosench13@gmail.com>
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com>
Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com>
Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com>
Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>
Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com>
Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com>
Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com>
Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com>
Co-authored-by: Amber Renton <amberrenton@microsoft.com>
Co-authored-by: jocawtho <jocawtho@microsoft.com>
Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: Alancere <804873052@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimLovellSmith TimLovellSmith TimLovellSmith approved these changes

@naveedaz naveedaz naveedaz approved these changes

@raosuhas raosuhas Awaiting requested review from raosuhas

Assignees

@rkmanda rkmanda

Labels

ARMReview resource-manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tbhartia @TimLovellSmith @naveedaz @raosuhas @rkmanda @AzureRestAPISpecReview @edwin-msft
⚡