Skip to content

Add AzureStorageProtocol field to AzureStorageInfoValue in latest API version#28289

Merged
naveedaz merged 1 commit intorelease-web-2023-12-01from
developer/amberrenton/add-azurestorageprotocol-field
Mar 30, 2024
Merged

Add AzureStorageProtocol field to AzureStorageInfoValue in latest API version#28289
naveedaz merged 1 commit intorelease-web-2023-12-01from
developer/amberrenton/add-azurestorageprotocol-field

Conversation

@amberrenton
Copy link
Copy Markdown
Member

@amberrenton amberrenton commented Mar 15, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • Adding additional field to upcoming latest API version.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@amberrenton amberrenton requested a review from naveedaz as a code owner March 15, 2024 23:13
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Mar 15, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Mar 15, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
Compared specs (v0.10.5) new version base version
CommonDefinitions.json 2023-12-01(6cd97c9) 2023-01-01(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-2023-12 package-2023-12(6cd97c9) package-2023-12(release-web-2023-12-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ GetCollectionResponseSchema The response in the GET collection operation 'Recommendations_ListRecommendedRulesForHostingEnvironment' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByHostingEnvironment' .
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L17
❌ GetCollectionResponseSchema The response in the GET collection operation 'Recommendations_ListRecommendedRulesForWebApp' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByWebApp' .
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L17
❌ GetCollectionResponseSchema The response in the GET collection operation 'WebApps_ListRelayServiceConnections' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnection' .
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L17
❌ GetCollectionResponseSchema The response in the GET collection operation 'WebApps_ListRelayServiceConnectionsSlot' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnectionSlot' .
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L17
❌ GetCollectionResponseSchema The response in the GET collection operation 'WebApps_ListPremierAddOns' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOn' .
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L17
❌ GetCollectionResponseSchema The response in the GET collection operation 'WebApps_ListPremierAddOnsSlot' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOnSlot' .
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L17
❌ GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L684
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L713
❌ ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L981
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L1024
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L1800
❌ NestedResourcesMustHaveListOperation The nested resource 'HybridConnection' does not have list operation, please add it.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L1819
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L1978
❌ GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2252
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2733
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2733
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2754
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2758
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2939
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2939
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L2939
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L3050
❌ GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L3097
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L3443
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L3465
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L3599
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L4141
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L4185
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L4185
❌ NestedResourcesMustHaveListOperation The nested resource 'VnetGateway' does not have list operation, please add it.
Location: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L4308
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Mar 15, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️SDK Breaking Change Tracking warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-java warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️🔄 azure-resource-manager-schemas inProgress [Detail]
️⚠️ azure-powershell warning [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Mar 15, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appservice/armappservice https://apiview.dev/Assemblies/Review/c5375c6f5a4443168e64c981277b8377?revisionId=bfcf2edda7ca4625abb4b675f9fd5d6d
Java azure-resourcemanager-appservice-generated https://apiview.dev/Assemblies/Review/a2b80e4fbd144844bca0c504ef8c3337?revisionId=5fa68b92aa42496783fe8c18c4fa36d5
JavaScript @azure/arm-appservice https://apiview.dev/Assemblies/Review/98dbdc8147d7472b9bdff567a8b291bc?revisionId=6b0764a27c9041b9aff39916107e02bf

@azure-sdk azure-sdk mentioned this pull request Mar 15, 2024
Closed
This was referenced Mar 15, 2024
Closed
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request Mar 15, 2024
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 15, 2024
@azure-sdk azure-sdk mentioned this pull request Mar 16, 2024
Closed
@ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 18, 2024
@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Mar 19, 2024
@naveedaz naveedaz merged commit d5672d7 into release-web-2023-12-01 Mar 30, 2024
@naveedaz naveedaz deleted the developer/amberrenton/add-azurestorageprotocol-field branch March 30, 2024 21:44
catalinaperalta pushed a commit that referenced this pull request Apr 20, 2024
@naveedaz @vkarasala
@xingyangli1278 @xingyang-li @crosenblatt @hdmimsft @Francisco-Gamino @vishal1997 @DJagwani @ha0ch1 @tbhartia @amberrenton @jocawtho @kazrael2119 @Alancere
Release web 2023 12 01 (#28268)
a50b142 
* Introduce Microsoft.Web API version 2023-12-01 (#27100)

* Add VnetBackupRestoreEnabled property to the latest API Version (#27175)

* changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317)

Co-authored-by: Xingyang Li <xingyangli@microsoft.com>

* e2e encryption (#27226)

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>

* Adding Vnet-related APIs to Swagger (#27251)

* Add function app config to latest Web API (#27358)

* Add functionAppConfig definition

* Add create or update function app Flex Consumption example

* Add create or update function app Flex Consumption with details example

* Update CommonDefinitions.json to reference the new examples

* Make PUT/PATCH api async for function on aca (#27612)

* Make PUT/PATCH api async for function on aca

* Remove response body

* update examples

* Add headers

---------

Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>

* Add FlexConsumption to the list of supported skus (#27951)

* Add TLS1.3 to valid TLS Versions (#27885)

Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm

* Added Linux SiteContainer APIs (#27942)

* Added Linux SiteContainer APIs

* Resolved validation failures.

* Added SiteContainer and SiteContainerCollection

* Fixed LintDiff errors

* Fixed spellings

* Updated params order.

* Resolving comments.

* Resolving comments.

* Added volumeMounts and envVariables.

* Resolving comments

* Resolving comments

* Removed type and metadata.

* Haochidu/release web 2023 12 01/aseregion hotfix (#28018)

* Update ResourceProvider.json

hot fix

API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification.

* Update ResourceProvider.json

* Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249)

This reverts commit 0765e9d.

* Add DnsConfiguration site property to Microsoft.Web API Specs (#27378)

* Add DnsConfiguration property to WebApps.json

* Add SiteDnsConfig to CommonDefinitions.json

* Updated dnslegacy property description

* Update CommonDefinitions.json

* Undo previous update to CommonDefinitions.json

* Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder

* Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289)

Co-authored-by: Amber Renton <amberrenton@microsoft.com>

* Update create function app examples for Flex Consumption (#28566)

* Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568)

This reverts commit cd214ae.

* Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738)

This reverts commit ec1d84f.

* create sdk-suppression.yaml (#28751)

* create sdk-suppression.yaml

* add azure-sdk-for-go suppression

---------

Co-authored-by: Alancere <804873052@qq.com>

---------

Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com>
Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com>
Co-authored-by: Xingyang Li <xingyangli@microsoft.com>
Co-authored-by: Chris Rosenblatt <rosench13@gmail.com>
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com>
Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com>
Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com>
Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>
Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com>
Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com>
Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com>
Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com>
Co-authored-by: Amber Renton <amberrenton@microsoft.com>
Co-authored-by: jocawtho <jocawtho@microsoft.com>
Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: Alancere <804873052@qq.com>
rkmanda pushed a commit that referenced this pull request Apr 20, 2024
@naveedaz @vkarasala
@xingyangli1278 @xingyang-li @crosenblatt @hdmimsft @Francisco-Gamino @vishal1997 @DJagwani @ha0ch1 @tbhartia @amberrenton @jocawtho @kazrael2119 @Alancere
Release web 2023 12 01 (#28268)
72f52bc 
* Introduce Microsoft.Web API version 2023-12-01 (#27100)

* Add VnetBackupRestoreEnabled property to the latest API Version (#27175)

* changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317)

Co-authored-by: Xingyang Li <xingyangli@microsoft.com>

* e2e encryption (#27226)

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>

* Adding Vnet-related APIs to Swagger (#27251)

* Add function app config to latest Web API (#27358)

* Add functionAppConfig definition

* Add create or update function app Flex Consumption example

* Add create or update function app Flex Consumption with details example

* Update CommonDefinitions.json to reference the new examples

* Make PUT/PATCH api async for function on aca (#27612)

* Make PUT/PATCH api async for function on aca

* Remove response body

* update examples

* Add headers

---------

Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>

* Add FlexConsumption to the list of supported skus (#27951)

* Add TLS1.3 to valid TLS Versions (#27885)

Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm

* Added Linux SiteContainer APIs (#27942)

* Added Linux SiteContainer APIs

* Resolved validation failures.

* Added SiteContainer and SiteContainerCollection

* Fixed LintDiff errors

* Fixed spellings

* Updated params order.

* Resolving comments.

* Resolving comments.

* Added volumeMounts and envVariables.

* Resolving comments

* Resolving comments

* Removed type and metadata.

* Haochidu/release web 2023 12 01/aseregion hotfix (#28018)

* Update ResourceProvider.json

hot fix

API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification.

* Update ResourceProvider.json

* Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249)

This reverts commit 0765e9d.

* Add DnsConfiguration site property to Microsoft.Web API Specs (#27378)

* Add DnsConfiguration property to WebApps.json

* Add SiteDnsConfig to CommonDefinitions.json

* Updated dnslegacy property description

* Update CommonDefinitions.json

* Undo previous update to CommonDefinitions.json

* Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder

* Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289)

Co-authored-by: Amber Renton <amberrenton@microsoft.com>

* Update create function app examples for Flex Consumption (#28566)

* Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568)

This reverts commit cd214ae.

* Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738)

This reverts commit ec1d84f.

* create sdk-suppression.yaml (#28751)

* create sdk-suppression.yaml

* add azure-sdk-for-go suppression

---------

Co-authored-by: Alancere <804873052@qq.com>

---------

Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com>
Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com>
Co-authored-by: Xingyang Li <xingyangli@microsoft.com>
Co-authored-by: Chris Rosenblatt <rosench13@gmail.com>
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com>
Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com>
Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com>
Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>
Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com>
Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com>
Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com>
Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com>
Co-authored-by: Amber Renton <amberrenton@microsoft.com>
Co-authored-by: jocawtho <jocawtho@microsoft.com>
Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: Alancere <804873052@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naveedaz naveedaz naveedaz approved these changes

Assignees

No one assigned

Labels

Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript resource-manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amberrenton @naveedaz @Alancere @AzureRestAPISpecReview @ms-zhenhua @kazrael2119
⚡