Skip to content

Fix possible endless loop while polling curl socket#5589

Merged
ahsonkhan merged 1 commit intoAzure:mainfrom
CurtizJ:main
May 16, 2024
Merged

Fix possible endless loop while polling curl socket#5589
ahsonkhan merged 1 commit intoAzure:mainfrom
CurtizJ:main

Conversation

@CurtizJ
Copy link
Copy Markdown
Contributor

@CurtizJ CurtizJ commented May 1, 2024 •
edited
Loading

In case of high frequency of received signals (more than once per second) the field now will never be updated and it can lead to exceeding of timeout or endless loop if socket will never be ready. For instance in ClickHouse signals SIGUSR1 and SIGUSR2 are being sent each second by internal query profiler and we faced this issue.

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@github-actions github-actions Bot added Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 1, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2024

Thank you for your contribution @CurtizJ! We will review the pull request and get back to you soon.

LarryOsterman
LarryOsterman approved these changes May 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Extremely good catch.

Is it possible to write a test for this?

@CurtizJ
Copy link
Copy Markdown
Contributor Author

CurtizJ commented May 2, 2024

Yes, I'll try to add a test.

@ahsonkhan
Copy link
Copy Markdown
Contributor

ahsonkhan commented May 6, 2024 •
edited
Loading

That's a great catch! I am curious, how did you discover this? Did you actually hit the endless loop, in your use case?

ahsonkhan
ahsonkhan reviewed May 6, 2024
View reviewed changes
Comment thread sdk/core/azure-core/src/http/curl/curl.cpp
@CurtizJ
Copy link
Copy Markdown
Contributor Author

CurtizJ commented May 13, 2024

how did you discover this?

We use this sdk for integration with azure blob storage in ClickHouse. I ran a stress test with heavy queries and after finishing it I noticed some hung queries with stacktrace on the line changed in this PR. I don't know why poll hasn't received any events, maybe because the connection was by timeout, but I didn't investigate it. After fixing this the issue has disappeared.

@CurtizJ
Copy link
Copy Markdown
Contributor Author

CurtizJ commented May 13, 2024

Sorry for the delay, it appeared to be harder to add test than I thought.

ahsonkhan
ahsonkhan approved these changes May 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LarryOsterman given this is a great reliability bug fix, I propose we merge it.

I'll make a changelog update PR, for core, attributing @CurtizJ for fixing this issue. Thanks!

@ahsonkhan ahsonkhan mentioned this pull request May 15, 2024
Merged
@ahsonkhan ahsonkhan merged commit 5d3f955 into Azure:main May 16, 2024
azure-sdk added a commit to azure-sdk/vcpkg that referenced this pull request Jul 12, 2024
@azure-sdk
[azure-core-cpp] Update to 1.13.0
9ea81dc 
## 1.13.0 (2024-07-12)

### Bugs Fixed

- [[microsoft#5589]](Azure/azure-sdk-for-cpp#5589) Fix possible endless loop while polling curl socket.  (A community contribution, courtesy of _[CurtizJ](https://github.com/CurtizJ)_)

### Other Changes

- Updated JSON library to 3.11.3.
- [[microsoft#5622]](Azure/azure-sdk-for-cpp#5622) Documentation fix for building the SDK with specific OpenSSL version.  (A community contribution, courtesy of _[ByteYue](https://github.com/ByteYue)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Anton Popov _([GitHub](https://github.com/CurtizJ))_
- AlexYue _([GitHub](https://github.com/ByteYue))_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LarryOsterman LarryOsterman LarryOsterman approved these changes

@antkmsft antkmsft antkmsft approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@gearama gearama Awaiting requested review from gearama

+1 more reviewer

@ahsonkhan ahsonkhan ahsonkhan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CurtizJ @ahsonkhan @RickWinter @LarryOsterman @antkmsft
⚡