Skip to content

correct command for using specified openssl with cmake#5622

Merged
ahsonkhan merged 1 commit intoAzure:mainfrom
ByteYue:correct_readme_command
May 16, 2024
Merged

correct command for using specified openssl with cmake#5622
ahsonkhan merged 1 commit intoAzure:mainfrom
ByteYue:correct_readme_command

Conversation

@ByteYue
Copy link
Copy Markdown
Contributor

@ByteYue ByteYue commented May 15, 2024

Pull Request Checklist

Hi there, I'm trying to integrate the Azure SDK into apache doris, and during the process, I found that I need to specify a particular version of OpenSSL. At this point, I discovered that the related commands in the documentation were incorrect, so I'm attempting to correct the documentation through this PR.

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@github-actions github-actions Bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 15, 2024
@github-actions
Copy link
Copy Markdown

Thank you for your contribution @ByteYue! We will review the pull request and get back to you soon.

@LarryOsterman
Copy link
Copy Markdown
Member

Thank you very much for catching my typo, the change looks good.

Let me know if you're done with verifying the fixes so I can merge the changes in.

Comment thread README.md
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented May 16, 2024

Thank you very much for catching my typo, the change looks good.

Let me know if you're done with verifying the fixes so I can merge the changes in.

Hi @LarryOsterman , sorry for my late response. I have already passed the verification, everything is fine now, and it’s ready to be merged.

@ahsonkhan ahsonkhan merged commit c95f74a into Azure:main May 16, 2024
azure-sdk added a commit to azure-sdk/vcpkg that referenced this pull request Jul 12, 2024
## 1.13.0 (2024-07-12)

### Bugs Fixed

- [[microsoft#5589]](Azure/azure-sdk-for-cpp#5589) Fix possible endless loop while polling curl socket.  (A community contribution, courtesy of _[CurtizJ](https://github.com/CurtizJ)_)

### Other Changes

- Updated JSON library to 3.11.3.
- [[microsoft#5622]](Azure/azure-sdk-for-cpp#5622) Documentation fix for building the SDK with specific OpenSSL version.  (A community contribution, courtesy of _[ByteYue](https://github.com/ByteYue)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Anton Popov _([GitHub](https://github.com/CurtizJ))_
- AlexYue _([GitHub](https://github.com/ByteYue))_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants