Skip to content

Use GetTestCredentials in eventhubs admin client; updated samples to allow sample execution to be disabled#5799

Merged
LarryOsterman merged 6 commits intoAzure:mainfrom
LarryOsterman:larryo/fix_eventhubs_credentials
Jul 16, 2024
Merged

Use GetTestCredentials in eventhubs admin client; updated samples to allow sample execution to be disabled#5799
LarryOsterman merged 6 commits intoAzure:mainfrom
LarryOsterman:larryo/fix_eventhubs_credentials

Conversation

@LarryOsterman
Copy link
Copy Markdown
Member

@LarryOsterman LarryOsterman commented Jul 15, 2024

…

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

RickWinter
RickWinter reviewed Jul 15, 2024
View reviewed changes
Comment thread cmake-modules/AzureBuildTargetForCI.cmake Outdated
@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp - attestation; cpp - identity; cpp - eventhubs

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2024

No pipelines are associated with this pull request.

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp - attestation

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp-identity

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp-keyvault

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2024

No pipelines are associated with this pull request.

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp-keyvault, cpp-attestation

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2024

No pipelines are associated with this pull request.

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp-attestation;cpp-keyvault

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2024

No pipelines are associated with this pull request.

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp help

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp-attestation, cpp-keyvault, cpp-eventhubs, cpp-identity

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2024

CI/CD Pipelines for this repository:

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 15, 2024

/azp run cpp - attestation, cpp - keyvault, cpp - identity, cpp - eventhubs

@Azure Azure deleted a comment from azure-pipelines Bot Jul 15, 2024
@Azure Azure deleted a comment from azure-pipelines Bot Jul 15, 2024
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2024

Azure Pipelines successfully started running 4 pipeline(s).

@LarryOsterman
Copy link
Copy Markdown
Member Author

LarryOsterman commented Jul 16, 2024

/azp run cpp - attestation, cpp - keyvault, cpp - identity, cpp - eventhubs

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 16, 2024

Azure Pipelines successfully started running 4 pipeline(s).

ahsonkhan
ahsonkhan reviewed Jul 16, 2024
View reviewed changes
Comment thread sdk/eventhubs/azure-messaging-eventhubs/test/ut/consumer_client_test.cpp
ahsonkhan
ahsonkhan reviewed Jul 16, 2024
View reviewed changes
Comment thread cmake-modules/AzureBuildTargetForCI.cmake Outdated
ahsonkhan
ahsonkhan reviewed Jul 16, 2024
View reviewed changes
Comment thread cmake-modules/AzureBuildTargetForCI.cmake Outdated
ahsonkhan
ahsonkhan approved these changes Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we can't add AzurePipelinesCredential to DefaultAzureCredential in the near future, it seems reasonable to skip running samples, but continue to build them as that has the most value in catching correctness issues.

Separately, I am trying to test out if we are able to use AzureCliCredential to run the samples, though hitting some unexpected and likely unrelated az cli and/or infra issue (specifically on Windows), which requires some investigation:
#5800

gearama
gearama reviewed Jul 16, 2024
View reviewed changes
Comment thread sdk/keyvault/azure-security-keyvault-certificates/CMakeLists.txt
@LarryOsterman LarryOsterman merged commit e19dc23 into Azure:main Jul 16, 2024
@ahsonkhan ahsonkhan mentioned this pull request Jul 18, 2024
Merged
@LarryOsterman LarryOsterman deleted the larryo/fix_eventhubs_credentials branch September 6, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RickWinter RickWinter RickWinter left review comments

@antkmsft antkmsft Awaiting requested review from antkmsft antkmsft is a code owner

@vinjiang vinjiang Awaiting requested review from vinjiang

@Jinming-Hu Jinming-Hu Awaiting requested review from Jinming-Hu

@EmmaZhu EmmaZhu Awaiting requested review from EmmaZhu

@microzchang microzchang Awaiting requested review from microzchang

@gkostal gkostal Awaiting requested review from gkostal gkostal is a code owner

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 is a code owner

@ahmadmsft ahmadmsft Awaiting requested review from ahmadmsft ahmadmsft is a code owner

@schaabs schaabs Awaiting requested review from schaabs

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from Azure/azure-sdk-write-identity

+2 more reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

@gearama gearama gearama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Attestation Azure.Identity Event Hubs KeyVault Storage Storage Service (Queues, Blobs, Files) Tables

Projects

Azure Identity SDK Improvements
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LarryOsterman @RickWinter @ahsonkhan @gearama
⚡