Re-enable running previously disabled samples using AzureCliCredential.#5818
Merged
ahsonkhan merged 5 commits intoAzure:mainfrom Jul 18, 2024
Merged
Re-enable running previously disabled samples using AzureCliCredential.#5818ahsonkhan merged 5 commits intoAzure:mainfrom
ahsonkhan merged 5 commits intoAzure:mainfrom
Conversation
ahsonkhan
added
EngSys
Contributor
Author
|
/azp run cpp - attestation, cpp - keyvault, cpp - identity, cpp - eventhubs |
This comment was marked as duplicate.
This comment was marked as duplicate.
that don't exist.
This was referenced Jul 18, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
ahsonkhan
requested review from
LarryOsterman,
RickWinter,
ahmadmsft,
anilba06,
antkmsft,
benbp,
danieljurek,
gearama,
gkostal and
weshaggard
as code owners
ahsonkhan
requested review from
KarishmaGhiya,
maorleger,
mpodwysocki,
pvaneck,
scottaddie and
xiangyan99
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
Author
|
FYI @weshaggard for review |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
gearama
approved these changes
Jul 18, 2024
RickWinter
approved these changes
Jul 18, 2024
weshaggard
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the SDK samples continue to build for all cross-platform CI pipelines that have
BUILD_SAMPLES=ON.We had previously disabled running the samples using
DISABLE_RUN: #5799 after turning FederatedAuth on, here: #5754This PR re-enables running most of the samples that can be run, using
AzureCliCredentialin an AzureCLI task, specifically on Ubuntu. Only the identity sampleclient_secret_credential_sampleis left disabled since it relies onAZURE_CLIENT_SECRETenv var being set, which we don't use anymore withFederatedAuth.It is not required for samples to only use
AzurePipelinesCredential. Any credential that doesn't require secrets set or shared is allowed (this includesAzureCliCredential,AzurePowershellCredential,ManagedIdentityCredential, etc.). SinceAzureCliCredentialis already part of the DAC (and C++ currently doesn't haveAzurePowershellCredential), that is a viable alternative.There is an on-going investigation why the AzureCLI@2 task behaves differently between Ubuntu and Windows. It works as expected on Ubuntu, so we limit our runs to that. See related issues: microsoft/azure-pipelines-tasks#20167 / actions/runner-images#10246
Previous experiments: #5800
Further details shared offline.
Since we already have unit/live tests, and the samples already get built, there are diminishing returns in running samples, and even more so across multiple OSes. C++ samples are compiled, so majority of the bugs/typos (especially if the API surface changes) will get caught at build time. Having them run in our CI is extra/nice to have. Therefore, it isn't required for us to run the samples on Windows. The only other language that runs the samples (as-is), is JS, while all the other language SDKs only build the samples. That is sufficient for most cases.
cc @RickWinter