Warn about VisualStudioCodeCredential not working in error message#30385
Merged
pvaneck merged 2 commits intoAzure:mainfrom May 15, 2023
Merged
Warn about VisualStudioCodeCredential not working in error message#30385pvaneck merged 2 commits intoAzure:mainfrom
pvaneck merged 2 commits intoAzure:mainfrom
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
pvaneck
approved these changes
May 12, 2023
Member
pvaneck
left a comment
There was a problem hiding this comment.
LGTM. Thanks for improving the error message!
|
Thank you for your contribution @basnijholt! We will review the pull request and get back to you soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
VisualStudioCodeCredentialhas not worked at all for more than a year. I wasted quite some time in writing code, documentation, and trying to get theVisualStudioCodeCredentialto work, only to find #23249 which reports it is currently not working with the Azure Account extension ≥0.9.11.Visual Studio Code automatically updates extensions so it's reasonable to assume people are not using a 1.5 year old version of this extension.
To prevent others from having to dig around, I propose to expand the error message that is printed when
DefaultAzureCredentialfails.Currently it prints:
However, with the code of this PR, it prints:
About 9 months ago @billwert reported a new solution is planned (#25713), however, there seems to be no developer activity yet.
Hopefully, with this change developers will understand to not build tooling (such as I did) that depends on this functionality.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines