Skip to content

Warn about VisualStudioCodeCredential not working in error message #30385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvaneck merged 2 commits into from
May 15, 2023
Merged

Warn about VisualStudioCodeCredential not working in error message #30385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b88cad
Warn about VisualStudioCodeCredential not working in error message
basnijholt May 12, 2023
bef350a
Update CHANGELOG
basnijholt May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Bugs Fixed

### Other Changes
- VisualStudioCodeCredential prints an informative error message when used (as it is currently broken) ([#30385](https://github.com/Azure/azure-sdk-for-python/pull/30385))

## 1.13.0 (2023-05-11)

Expand Down
8 changes: 7 additions & 1 deletion sdk/identity/azure-identity/azure/identity/_credentials/vscode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,13 @@ def _get_refresh_token(self) -> str:
if not self._refresh_token:
self._refresh_token = get_refresh_token(self._cloud)
if not self._refresh_token:
raise CredentialUnavailableError(message="Failed to get Azure user details from Visual Studio Code.")
message = (
"Failed to get Azure user details from Visual Studio Code. "
"Currently, the VisualStudioCodeCredential only works with the Azure "
"Account extension version 0.9.11 and earlier. A long-term fix is in "
"progress, see https://github.com/Azure/azure-sdk-for-python/issues/25713"
)
raise CredentialUnavailableError(message=message)
return self._refresh_token

def _initialize(self, vscode_user_settings: Dict, **kwargs: Any) -> None:
Expand Down
⚡