[CI] Test updates for central sanitizers#35385
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
Closed
9549512 to
9492e67
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
b161508 to
4fd4360
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
xiangyan99
approved these changes
May 7, 2024
mccoyp
reviewed
May 7, 2024
mccoyp
approved these changes
May 7, 2024
Member
mccoyp
left a comment
There was a problem hiding this comment.
Thank you so much for this work!
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates our Python testing framework to adopt the new TestProxy which enables numerous common sanitizers.
Since these new common sanitizers might be considered too aggressive in some cases, a new API was added to
devtools_testutilsto remove specific sanitizers:remove_batch_sanitizers. With this new method, SDK owners can opt out of certain sanitizers by passing in a list of sanitizer IDs toremove_batch_sanitizersin theirconftest.pyfiles. For example:The list of sanitizers and their IDs can be viewed here. When a sanitizer is opted out of, it's important to be sure that the non-sanitized data is non-sensitive.
Other changes in this PR:
set_common_sanitizersmethod since these are applied by TestProxy itself.generate_sasfunction since TestProxy sanitizers will handle sanitization ofse,st, andsigURI query parameters. Tests and recordinings using this function should not break with this PR.assets.jsonfiles.add_sanitizermethods were updated to be session-scoped improving, massively improving testing performance.