Conversation
Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
…e-sdk-tools into add-common-sanitizers
…preparation to release. Need to roll out the ability to deregister sanitizers sooner rather than later
|
Does the proxy already have a way to deduplicate sanitizers so we don't run all of these twice? If not, I imagine it could compare two sanitizers with hashes of their string parameters |
It does not at this time. We will pay the cost for now. I have another PR in the works that makes sanitizers set/get/remove from a single abstraction class. Doing this hash check there would make the most sense if we do it 👍 |
…itional characters -- to include space, newline, backslash, and comma Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
…iguration.cs Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
|
Thank you to all the reviewers on this PR: @pvaneck , @JoshLove-msft , @chlowell, @samvaity, and @benbp . Hugely appreciate all your feedback.
|
|
/check-enforcer evaluate |
This PR moves the test-proxy from a static append-only set of sanitizers, to an actual data structure with proper addition/removal of applied sanitizers.
/Admin/AddSanitizersorAdmin/AddSanitizer, an object or list of objects representing the registered sanitizers is now returned to the calling client. These objects contain the base sanitizer properties + theidof the registered sanitizer./Admin/RemoveSanitizerswhich can apply to either the session-level or an individual playback/record session.Observers please add suggestions either in discussion or directly onto the branch.