[TestProxy] Common Sanitizers

tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/InfoTests.cs

@@ -18,6 +18,8 @@ namespace Azure.Sdk.Tools.TestProxy.Tests
 {
     public class InfoTests
     {
+        private int DefaultExtensionCount { get { return new RecordingHandler(null).SanitizerRegistry.GetSanitizers().Count; } }
+
         [Fact]
         public void TestReflectionModelBuild()
         {
@@ -79,17 +81,17 @@ public async Task TestReflectionModelWithTargetRecordSession()
             var model = new ActiveMetadataModel(testRecordingHandler, recordingId);
             var descriptions = model.Descriptions.ToList();
 
-            // we should have exactly 6 if we're counting all the customizations appropriately
-            Assert.True(descriptions.Count == 6);
+            // we should have exactly DefaultExtensionCount + 2 if we're counting all the customizations appropriately
+            Assert.True(descriptions.Count == DefaultExtensionCount + 3);
             Assert.True(model.Matchers.Count() == 1);
-            Assert.True(model.Sanitizers.Count() == 5);
+            Assert.True(model.Sanitizers.Count() == DefaultExtensionCount + 2);
 
             // confirm that the overridden matcher is showing up
-            Assert.True(descriptions[3].ConstructorDetails.Arguments[1].Item2 == "\"ABC123\"");
-            Assert.True(descriptions[4].ConstructorDetails.Arguments[1].Item2 == "\".+?\"");
+            Assert.True(descriptions[DefaultExtensionCount].ConstructorDetails.Arguments[1].Item2 == "\"ABC123\"");
+            Assert.True(descriptions[DefaultExtensionCount + 1].ConstructorDetails.Arguments[1].Item2 == "\".+?\"");
 
             // and finally confirm our sanitizers are what we expect
-            Assert.True(descriptions[5].Name == "CustomDefaultMatcher");
+            Assert.True(descriptions[DefaultExtensionCount + 2].Name == "CustomDefaultMatcher");
         }
     }
 }

tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/LoggingTests.cs

@@ -52,7 +52,7 @@ public async Task PlaybackLogsSanitizedRequest()
                 HttpResponse response = new DefaultHttpContext().Response;
                 await testRecordingHandler.HandlePlaybackRequest(recordingId, request, response);
 
-                AssertLogs(logger, 4, 8);
+                AssertLogs(logger, 4, 8, 7);
             }
             finally
             {
@@ -92,7 +92,7 @@ public async Task RecordingHandlerLogsSanitizedRequests()
 
             try
             {
-                AssertLogs(logger, 2, 8);
+                AssertLogs(logger, 2, 8, 12);
             }
             finally
             {
@@ -101,7 +101,7 @@ public async Task RecordingHandlerLogsSanitizedRequests()
             }
         }
 
-        private static void AssertLogs(TestLogger logger, int offset, int expectedLength)
+        private static void AssertLogs(TestLogger logger, int offset, int expectedLength, int expectedContentLength)
         {
             Assert.Equal(expectedLength, logger.Logs.Count);
             Assert.Equal(
@@ -116,10 +116,10 @@ private static void AssertLogs(TestLogger logger, int offset, int expectedLength
             Assert.Equal(
                 "Request Body Content{\"key\":\"Location\",\"value\":\"https://fakeazsdktestaccount.table.core.windows.net/Tables\"}",
                 logger.Logs[2 + offset].ToString());
-            Assert.Equal("URI: [ https://fakeazsdktestaccount.table.core.windows.net/Tables]" +
+            Assert.Equal("URI: [ https://REDACTED.table.core.windows.net/Tables]" +
                          Environment.NewLine + "Headers: [{\"Accept\":[\"application/json;odata=minimalmetadata\"],\"Accept-Encoding\":[\"gzip, deflate\"],\"Authorization\":[\"Sanitized\"],\"Connection\":[\"keep-alive\"]," +
-                         "\"Content-Length\":[\"12\"],\"Content-Type\":[\"application/octet-stream\"],\"DataServiceVersion\":[\"3.0\"],\"Date\":[\"Tue, 18 May 2021 23:27:42 GMT\"]," +
-                         "\"User-Agent\":[\"azsdk-python-data-tables/12.0.0b7 Python/3.8.6 (Windows-10-10.0.19041-SP0)\"],\"x-ms-client-request-id\":[\"a4c24b7a-b830-11eb-a05e-10e7c6392c5a\"]," +
+                         "\"Content-Length\":[\"" + expectedContentLength + "\"],\"Content-Type\":[\"application/octet-stream\"],\"DataServiceVersion\":[\"3.0\"],\"Date\":[\"Tue, 18 May 2021 23:27:42 GMT\"]," +
+                         "\"User-Agent\":[\"azsdk-python-data-tables/12.0.0b7 Python/3.8.6 (Windows-10-10.0.19041-SP0)\"],\"x-ms-client-request-id\":[\"Sanitized\"]," +
                          "\"x-ms-date\":[\"Tue, 18 May 2021 23:27:42 GMT\"],\"x-ms-version\":[\"2019-02-02\"]}]" + Environment.NewLine,
                 logger.Logs[3 + offset].ToString());
         }

tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/RecordingHandlerTests.cs

@@ -29,6 +29,8 @@ namespace Azure.Sdk.Tools.TestProxy.Tests
 {
     public class RecordingHandlerTests
     {
+        private int DefaultExtensionCount { get { return new RecordingHandler(null).SanitizerRegistry.DefaultSanitizerList.Count; } }
+
         #region helpers and private test fields
         private HttpContext GenerateHttpRequestContext(string[] headerValueStrings)
         {
@@ -97,11 +99,15 @@ private void _checkDefaultExtensions(RecordingHandler handlerForTest, CheckSkips
 
             if (skipsToCheck.HasFlag(CheckSkips.IncludeSanitizers))
             {
-                var sessionSanitizers = handlerForTest.SanitizerRegistry.GetSanitizers();
-                Assert.Equal(3, sessionSanitizers.Count);
-                Assert.IsType<RecordedTestSanitizer>(sessionSanitizers[0]);
-                Assert.IsType<BodyKeySanitizer>(sessionSanitizers[1]);
-                Assert.IsType<BodyKeySanitizer>(sessionSanitizers[2]);
+
+                var sanitizers = handlerForTest.SanitizerRegistry.GetSanitizers();
+
+                Assert.Equal(DefaultExtensionCount, sanitizers.Count);
+                Assert.IsType<RecordedTestSanitizer>(sanitizers[0]);
+                Assert.IsType<BodyKeySanitizer>(sanitizers[1]);
+                Assert.IsType<BodyKeySanitizer>(sanitizers[2]);
+                Assert.IsType<HeaderRegexSanitizer>(sanitizers[75]);
+                Assert.IsType<BodyRegexSanitizer>(sanitizers[108]);
             }
         }
         #endregion
@@ -302,7 +308,7 @@ public async Task TestLoadOfAbsoluteRecording()
             var playbackSession = recordingHandler.PlaybackSessions.First();
             var entry = playbackSession.Value.Session.Entries.First();
 
-            Assert.Equal("https://login.microsoftonline.com/12345678-1234-1234-1234-123456789012/oauth2/v2.0/token", entry.RequestUri);
+            Assert.Equal("https://REDACTED.microsoftonline.com/12345678-1234-1234-1234-123456789012/oauth2/v2.0/token", entry.RequestUri);
         }
 
         [Fact]
@@ -318,7 +324,7 @@ public async Task TestLoadOfRelativeRecording()
             var playbackSession = recordingHandler.PlaybackSessions.First();
             var entry = playbackSession.Value.Session.Entries.First();
 
-            Assert.Equal("https://login.microsoftonline.com/12345678-1234-1234-1234-123456789012/oauth2/v2.0/token", entry.RequestUri);
+            Assert.Equal("https://REDACTED.microsoftonline.com/12345678-1234-1234-1234-123456789012/oauth2/v2.0/token", entry.RequestUri);
         }
 
         [Fact]
@@ -445,7 +451,7 @@ public async Task TestCanSkipRecordingEntireRequestResponse()
                 var record = RecordSession.Deserialize(doc.RootElement);
                 Assert.Single(record.Entries);
                 var entry = record.Entries.First();
-                Assert.Equal("value", JsonDocument.Parse(entry.Request.Body).RootElement.GetProperty("key").GetString());
+                Assert.Equal("Sanitized", JsonDocument.Parse(entry.Request.Body).RootElement.GetProperty("key").GetString());
                 Assert.Equal(MockHttpHandler.DefaultResponse, Encoding.UTF8.GetString(entry.Response.Body));
             }
             finally

tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/TransformTests.cs

@@ -1,4 +1,4 @@
-using Azure.Sdk.Tools.TestProxy.Common;
+using Azure.Sdk.Tools.TestProxy.Common;
 using Azure.Sdk.Tools.TestProxy.Transforms;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
@@ -132,14 +132,14 @@ public async Task ApiTransformPullsFromRequest()
         public async Task CanApplyHeaderTransformWithCondition()
         {
             var headerTransform = new HeaderTransform(
-                "Location",
-                "http://localhost",
+                "X-Content-Type-Options",
+                "replaced",
                 condition: new ApplyCondition
                 {
                     ResponseHeader = new HeaderCondition
                     {
-                        Key = "Location",
-                        ValueRegex = @".*/Tables\(.*"
+                        Key = "X-Content-Type-Options",
+                        ValueRegex = ".*nosniff.*"
                     }
                 });
             RecordingHandler testRecordingHandler = new RecordingHandler(Directory.GetCurrentDirectory());
@@ -170,15 +170,15 @@ public async Task CanApplyHeaderTransformWithCondition()
             HttpRequest request = TestHelpers.CreateRequestFromEntry(transformedEntry);
             HttpResponse response = new DefaultHttpContext().Response;
             await testRecordingHandler.HandlePlaybackRequest(recordingId, request, response);
-            Assert.Equal("http://localhost", response.Headers["Location"]);
+            Assert.Equal("replaced", response.Headers["X-Content-Type-Options"]);
 
             // this one should keep the original Location value
             request = TestHelpers.CreateRequestFromEntry(untransformedEntry);
             response = new DefaultHttpContext().Response;
             await testRecordingHandler.HandlePlaybackRequest(recordingId, request, response);
             var originalLocation = untransformedEntry.Response.Headers["Location"];
 
-            Assert.Equal(originalLocation, response.Headers["Location"]);
+            Assert.NotEqual(originalLocation, response.Headers["Location"]);
         }
     }
 }