Skip to content

[Identity] Add AzurePipelinesCredential#35397

Merged
pvaneck merged 5 commits intoAzure:mainfrom
pvaneck:azure-pipelines-credential
May 10, 2024
Merged

[Identity] Add AzurePipelinesCredential#35397
pvaneck merged 5 commits intoAzure:mainfrom
pvaneck:azure-pipelines-credential

Conversation

@pvaneck
Copy link
Copy Markdown
Member

@pvaneck pvaneck commented Apr 27, 2024

Add a new credential, AzurePipelinesCredential.

Closes: #32143

@pvaneck pvaneck force-pushed the azure-pipelines-credential branch from 6a499db to 8af09b5 Compare April 29, 2024 08:27
@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

@pvaneck pvaneck force-pushed the azure-pipelines-credential branch 2 times, most recently from 7e177ff to 0125731 Compare May 6, 2024 22:21
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck force-pushed the azure-pipelines-credential branch from 0125731 to 8d6c57d Compare May 6, 2024 22:33
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck force-pushed the azure-pipelines-credential branch from c180a1b to 9d5e39c Compare May 7, 2024 02:00
@pvaneck pvaneck marked this pull request as ready for review May 9, 2024 01:29
@pvaneck pvaneck requested review from a team and xiangyan99 as code owners May 9, 2024 01:29
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azure_pipelines.py Outdated
Comment thread sdk/identity/azure-identity/README.md Outdated
pvaneck added 2 commits May 9, 2024 18:50
- Also moved credential in README.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck
Copy link
Copy Markdown
Member Author

pvaneck commented May 9, 2024

Note: The live tests for this credential have passed, and the failures (affecting everyone) are from expired keys/secrets. Those will need to be investigated/rotated.

Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azure_pipelines.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_pipelines.py Outdated
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@pvaneck pvaneck merged commit 17daed1 into Azure:main May 10, 2024
@pvaneck pvaneck deleted the azure-pipelines-credential branch May 10, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Add Support for Workload Identity Federation for Azure Service Connections

5 participants