Conversation
praveenkuttappan
approved these changes
Jun 11, 2024
Member
praveenkuttappan
left a comment
There was a problem hiding this comment.
Looks fine. Only additional change I prefer to have is to support deployment of just the UI test instance.
Currently following are the deployment patterns.
- APIView UI test is deployed for some testing and demo purposes (Less frequent deployment).
- APIView stage gets auto deployed anytime a new change is merged to main branch. So staging can be run pretty much as a CI job.
- APIView production deployment is done manually.
…Publish Test UI and Production Publish stages manual approval
Member
Author
Ok Praveen, I've made the following adjustments.
Please give a more detailed look at the release stages, then I'm going to pull the trigger on this thing :D |
Member
Author
|
Awaiting one last deployment to production slot, then this is ready to merge. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is related to #7941
This PR eliminates the need for the following standalone releases, and ensures that APIView is compliant with security needs.
When queuing manually from
internal, users will be prompted for a target environmentprodorstaging.stagingenables access to #1 and #2 in the list above.prodenables #3 only.Ready to test the actual releases.
New Stage Flow
Build and Test -> Staging (automatic) -> Production (approve required) -> Test UI (approve required)