Bump @fluentui/react dependency to 8.98.3#2415
Conversation
JamesBurnside
changed the title
@fluentui/react dependency to 8.98.3@fluentui/react dependency to 8.98.3
CallWithChat bundle size is increased❗.
|
Chat bundle size is increased❗.
|
Calling bundle size is increased❗.
|
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
| }); | ||
| const component = mountWithLocalization(<CameraButton showLabel={true} />, testLocale); | ||
| expect(component.text()).toBe(testLocale.strings.cameraButton.offLabel); | ||
| expect(component.find('button').text()).toBe(testLocale.strings.cameraButton.offLabel); |
There was a problem hiding this comment.
If you are curious why these unit tests needed updated, Fluent (for A11y reasons) now have the tooltip text rendered in the element but hidden when not hovered:
This caused the enzyme .text() to pick up the hidden content as it's not a very smart function, so the unit test has been updated to instead only grab the text from the button element (given this is what we are testing anyway):
There was a problem hiding this comment.
Maybe this is a change to also be called out in the web UI channel so people know going forward this is needed for tests?
| }); | ||
| const component = mountWithLocalization(<CameraButton showLabel={true} />, testLocale); | ||
| expect(component.text()).toBe(testLocale.strings.cameraButton.offLabel); | ||
| expect(component.find('button').text()).toBe(testLocale.strings.cameraButton.offLabel); |
There was a problem hiding this comment.
Maybe this is a change to also be called out in the web UI channel so people know going forward this is needed for tests?
5 participants
What
Bump
@fluentui/reactdependency to8.98.3Why
This version has the new react peer dependencies that allow v18 (and all the fluent fixes to support react 18).
This PR just updates the fluent dependency and does not change our react peer dependency versions yet
How Tested