Update/remove further dependencies that relied on react 17#2427
Merged
JamesBurnside merged 5 commits intomainfrom Oct 21, 2022
Merged
Update/remove further dependencies that relied on react 17#2427JamesBurnside merged 5 commits intomainfrom
JamesBurnside merged 5 commits intomainfrom
Conversation
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
JamesBurnside
commented
Oct 21, 2022
| const liveAuthor = _formatString(props.liveAuthorIntro, { author: `${props.message.senderDisplayName}` }); | ||
| return ( | ||
| <div data-ui-status={props.message.status} role="text" aria-text={props.messageContentAriaText}> | ||
| <div data-ui-status={props.message.status} role="text" aria-label={props.messageContentAriaText}> |
Member
Author
There was a problem hiding this comment.
rush update - p updated the eslint minor version which caused this new lint error
Contributor
mgamis-msft
approved these changes
Oct 21, 2022
prprabhu-ms
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update following deps that listed react 17 as peer dep that need updating:
@fluentui/react-hooks@fluentui/react-window-providerAlso removed unused dependencies that specified react 17 as a peer dep in the lockfile for cleanup. These don't impact the npm package but will make the repo upgrade to react 18 easier.
Why
Continuation of #2415 to support react 18
To see the full list of items to upgarde see this doc: https://microsoft.sharepoint-df.com/:w:/t/IC3SDK/EYInxewzAmJDvJaoCZhLTgsBvmY_YLpa82v-zTp3WDbhgA?e=DSNdP8
How Tested
Relying on CI for dep bumps