Star Survey inside call composite #3604
Merged
carocao-msft merged 1 commit intocarocao/surveyfrom Oct 17, 2023
Merged
Conversation
carocao-msft
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
| aria-atomic | ||
| > | ||
| {/* @conditional-compile-remove(end-of-call-survey) */ | ||
| <StarSurvey/>} |
Member
There was a problem hiding this comment.
This looks like this will always render no matter which kind of notice page this is. Should we be making sure that this is something that is only on the end call screen? this will show if you were kicked as well for example, is this something we want?
Contributor
Author
There was a problem hiding this comment.
I posted the question in the feature weekly, it feels like it makes more sense to show across the notice page? Calling wants to get as many data as possible :) but I am also not certain at a end user stand point this will be annoying
Member
There was a problem hiding this comment.
the question to me for including it when the user is removed or disconnects is whether contoso would want feedback in those situations. Thinking about feedback from being removed from the call they might want to leave negative feedback that is "less than constructive." if we also look at it from the Teams perspective they only request feedback when the call ends naturally, if the end call reason was a disconnection the SDK team can report that.
Contributor
Author
There was a problem hiding this comment.
https://github.com/Azure/communication-ui-library/pull/3608/files Addressed this issue in this pr, survey is only shown on end call page now
Contributor
There was a problem hiding this comment.
Does everything in here need to be conditionally compiled?
StarSurvey is internal so it's probably not needed.
Or is there something up the tree of commands which causes errors if this is not conditionally compiled?
Contributor
Author
There was a problem hiding this comment.
Those import statements causes errors if not conditionally compiled so we have to cc all of them. We do this for other internal composite components too
dmceachernmsft
approved these changes
Sep 29, 2023
edwardlee-msft
approved these changes
Sep 29, 2023
carocao-msft
added a commit
that referenced
this pull request
Dec 14, 2023
* survey * star; * star survey * Change files * Duplicate change files for beta release * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey (#3604) * [Chat] Removed bottom paddings for the edit message buttons (#3683) * [bugfix] calling version fix (#3685) * update entry point to latest calling beta * Change files * Duplicate change files for beta release * [Dependency Update] Rush -> 5.109.1 (#3687) * [Dependency Updates] Merge updates from v2 branch (part 1) (#3690) * Update backward-compatible packages * Update api-extractor and api-documentor * Alkwa/remove captions icon fade in (#3688) * adding in fluent prop to not fade in the persona * Change files * adding changelog entry * Merge Prerelease stable minor/1.9.0 into main (#3666) * stable-minor version bump * Collect CHANGELOG * Groom changelog for 1.9.0 stable release (#3664) * Create groom me file for groom changelog branch * Groom changelog for 1.9.0 stable release * Change files * Duplicate change files for beta release --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Bump package versions to beta.0 for next release --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * latest api * Update .babelrc.js Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> * componet changes * componet changes * linter * api * pr change * API tag survey component (#3607) * star survey * tag survey * tag survey * tag survey * componet changes * componet changes * componet changes * componet changes * Change files * Duplicate change files for beta release * pr change * Survey inside composite (#3608) * tag survey * tag survey * tag survey * tag survey * tag survey * tag survey * Add jest test coverage (#3577) * Capabilities doc in storybook (#3585) * Add storybook documentation for capabilities * Change files * Duplicate change files for beta release * major edit * lint fix * change 'Handling changes of capabilities' to 'Listening for changes in capabilities' * fix snippet code * rewording * wording fixes * typo fix * [CI fix] downgrade playwright (#3601) * downgrade playwright * Change files * Duplicate change files for beta release * [Gallery layouts] default gallery grid participant cap (#3574) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * cleanup per comments * Update logic to mix audtio video non dynamic * remove largeGallery API --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery Layouts] Large Gallery (#3591) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * Update logic to mix audtio video non dynamic * remove largeGallery API * make large gallery alpha only * Address comments * fix cc * Update packages/react-composites CallComposite browser test snapshots * fix comment --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery layouts] Large gallery e2e (#3597) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * add test * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * remove test.only * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots * Update logic to mix audtio video non dynamic * remove largeGallery API * make large gallery alpha only * Address comments * fix cc * Update packages/react-composites CallComposite browser test snapshots * fix comment * update to correct cc * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update license to License (including lint rule) (#3588) * [Pipeline] New comment to explain issue (#3613) * Treeshaking Locales and Reduced Bundle Size (#3615) * Treeshake locales * Treeshake locales from composites * minor * Change files * Duplicate change files for beta release * minor changes * [Gallery Layouts] mobile gallery options (#3603) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * add test * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * remove test.only * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots * add options to drop down * remove largeGallery from Mobile * fix scrollable gallery * Change files * Duplicate change files for beta release * add show label in default view always * fix lint * fix build * fix cc * Update packages/react-composites CallWithChatComposite browser test snapshots * rebuild API * Update packages/react-composites CallComposite browser test snapshots * fix double large button * update cc * build API * Update packages/react-composites CallComposite browser test snapshots * add auto dismiss on selection * add focused content to mobile * add icons representing selected mode * disable for hold screen --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery layouts] Mobile gallery e2e testing (#3611) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * add test * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * remove test.only * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots * add options to drop down * remove largeGallery from Mobile * fix scrollable gallery * Change files * Duplicate change files for beta release * add show label in default view always * fix lint * fix build * fix cc * Update packages/react-composites CallWithChatComposite browser test snapshots * rebuild API * Update packages/react-composites CallComposite browser test snapshots * fix double large button * update cc * build API * Update packages/react-composites CallComposite browser test snapshots * Add test * add auto dismiss on selection * Change files * Duplicate change files for beta release * remove test.only * Update packages/react-composites CallComposite browser test snapshots * add focused content to mobile * add icons representing selected mode * disable for hold screen * update test to have video people * remove test.only * add test to see menu options in bottom sheet * remove test.only * fix cc * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [A11y bugfix] Video effects pane focus focus issue (#3627) * update how to search for key * Change files * Duplicate change files for beta release * default render of participant list item will yield none for presence (#3619) * default render of participant list item will yield none for presence * Change files * Duplicate change files for beta release * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Chat] Updating storybook anchors to use ref (#3625) * [Gallery layouts] Update storybook for gallery layouts (#3616) * update storybook for gallery layouts * Change files * Duplicate change files for beta release * Update packages/storybook/stories/VideoGallery/VideoGallery.stories.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Update packages/storybook/stories/CallComposite/CallCompositeDocs.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * add missing layout to storybook controls * fix prettier * videogallery QOL improvements * move layout state to composite * track overflow gallery position in composite * fix build * large gallery fixes --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> * [Bug fix] configuration page fixes (#3621) * update mobile margins start call styles * update drop down styles * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update embed html bundle snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update embed html bundle snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * fix config margins * fix rejoin call button styles * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Chat] Long Display name truncation (#3633) * Improve compliance banner preview (#3635) * Improve ComplianceBanner preview in storybook * Change files * Duplicate change files for beta release * [bugfix] contextual menu overflow menu items extend background color and Call readiness prompt opacity lightened (#3639) * Apply background color to overflow menu items in contextual menu and lighten opacity for call readiness prompts * Increase outer padding of local PIP starting location (#3605) * Increase the gap of the floating local video's initial posiition from the bottom right * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery Layouts] Update composite options and icons for public preview (#3637) * update CC for beta release * Change files * Duplicate change files for beta release * Fix mobile drawer * Update packages/react-composites CallWithChatComposite browser test snapshots * fix strings * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Remove Fluent NorthStar (#3578) * Remove Fluent NorthStar * Replace Chat components with fluent 9 and fluent-contrib-chat * Update styling for various bug fixes * Update storybook and documentation --------- Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> * [Gallery Layouts] Release notes Changelogs (#3645) * [Image Gallery] Release notes Changelogs (#3646) * Change files * Duplicate change files for beta release --------- Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> * [Chat] Remove unnecessary FocusTrapZone for ImageGallery (#3569) * Remove FocusTrapZone from ImageGallery * Change files * Duplicate change files for beta release * Remove unnecessary imports * [Gallery layouts] ARB updates (#3649) * make adjustments for ARB * Change files * Duplicate change files for beta release * [Gallery layouts] fix gallery layout cc in snapshot tests (#3655) * update cc * Change files * Duplicate change files for beta release * overflow tests * Documentation update to remove NorthStar dependency information (#3650) * [BugFix] Update MyMessage options menu to correct size/visibility on mobile browsers (#3654) * [Gallery layouts] more gallery cc fixes for beta release (#3656) * update CC for tests * Change files * Duplicate change files for beta release --------- Co-authored-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * [Vertical Gallery] vertical gallery string update (#3652) * update verticalGallery key * Change files * Duplicate change files for beta release * 1.9.0-beta.1 Fetch Strings (#3660) * TDBuild - updating localized resource files. * TDBuild - updating localized resource files. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Bug fix]Decrease captions banner width when screen is too small to prevent more button overlapping with scroll bar (#3653) * width * Change files * Duplicate change files for beta release * [Chat] Updated Docs for Inline Image and File Sharing (#3599) * [Sample apps] add strict mode to sample apps again (#3659) * re introduce strict mode to samples * Change files * Duplicate change files for beta release * [Bug Fix] Allow custom avatar for captions component (#3643) * test changes to show how to get custom avatars in captions * Treeshaking Locales and Reduced Bundle Size (#3615) * Treeshake locales * Treeshake locales from composites * minor * Change files * Duplicate change files for beta release * minor changes * [Gallery Layouts] mobile gallery options (#3603) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * add test * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * remove test.only * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots * add options to drop down * remove largeGallery from Mobile * fix scrollable gallery * Change files * Duplicate change files for beta release * add show label in default view always * fix lint * fix build * fix cc * Update packages/react-composites CallWithChatComposite browser test snapshots * rebuild API * Update packages/react-composites CallComposite browser test snapshots * fix double large button * update cc * build API * Update packages/react-composites CallComposite browser test snapshots * add auto dismiss on selection * add focused content to mobile * add icons representing selected mode * disable for hold screen --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery layouts] Mobile gallery e2e testing (#3611) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * add test * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * remove test.only * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots * add options to drop down * remove largeGallery from Mobile * fix scrollable gallery * Change files * Duplicate change files for beta release * add show label in default view always * fix lint * fix build * fix cc * Update packages/react-composites CallWithChatComposite browser test snapshots * rebuild API * Update packages/react-composites CallComposite browser test snapshots * fix double large button * update cc * build API * Update packages/react-composites CallComposite browser test snapshots * Add test * add auto dismiss on selection * Change files * Duplicate change files for beta release * remove test.only * Update packages/react-composites CallComposite browser test snapshots * add focused content to mobile * add icons representing selected mode * disable for hold screen * update test to have video people * remove test.only * add test to see menu options in bottom sheet * remove test.only * fix cc * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [A11y bugfix] Video effects pane focus focus issue (#3627) * update how to search for key * Change files * Duplicate change files for beta release * default render of participant list item will yield none for presence (#3619) * default render of participant list item will yield none for presence * Change files * Duplicate change files for beta release * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Chat] Updating storybook anchors to use ref (#3625) * [Gallery layouts] Update storybook for gallery layouts (#3616) * update storybook for gallery layouts * Change files * Duplicate change files for beta release * Update packages/storybook/stories/VideoGallery/VideoGallery.stories.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Update packages/storybook/stories/CallComposite/CallCompositeDocs.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * add missing layout to storybook controls * fix prettier * videogallery QOL improvements * move layout state to composite * track overflow gallery position in composite * fix build * large gallery fixes --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> * [Bug fix] configuration page fixes (#3621) * update mobile margins start call styles * update drop down styles * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update embed html bundle snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update embed html bundle snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * fix config margins * fix rejoin call button styles * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Chat] Long Display name truncation (#3633) * Improve compliance banner preview (#3635) * Improve ComplianceBanner preview in storybook * Change files * Duplicate change files for beta release * [bugfix] contextual menu overflow menu items extend background color and Call readiness prompt opacity lightened (#3639) * Apply background color to overflow menu items in contextual menu and lighten opacity for call readiness prompts * Increase outer padding of local PIP starting location (#3605) * Increase the gap of the floating local video's initial posiition from the bottom right * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery Layouts] Update composite options and icons for public preview (#3637) * update CC for beta release * Change files * Duplicate change files for beta release * Fix mobile drawer * Update packages/react-composites CallWithChatComposite browser test snapshots * fix strings * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * tag survey * Change files * Duplicate change files for beta release * [Gallery Layouts] mobile gallery options (#3603) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * add test * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * remove test.only * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots * add options to drop down * remove largeGallery from Mobile * fix scrollable gallery * Change files * Duplicate change files for beta release * add show label in default view always * fix lint * fix build * fix cc * Update packages/react-composites CallWithChatComposite browser test snapshots * rebuild API * Update packages/react-composites CallComposite browser test snapshots * fix double large button * update cc * build API * Update packages/react-composites CallComposite browser test snapshots * add auto dismiss on selection * add focused content to mobile * add icons representing selected mode * disable for hold screen --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery layouts] Mobile gallery e2e testing (#3611) * update logic to cap gallery participants * put leftovers into overflow * fix indexing issue * Change files * Duplicate change files for beta release * build files * Update packages/react-composites CallComposite browser test snapshots * update tests for new tile caps * add new layout * add large gallery dropdown * add internal component to video gallery * add logic for large gallery * Change files * Duplicate change files for beta release * add tile count maxing at 48 less if no room * build fixes * cleanup per comments * fix cc * add test * Update packages/react-composites CallComposite browser test snapshots * fix cc * fix cc * remove test.only * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots * add options to drop down * remove largeGallery from Mobile * fix scrollable gallery * Change files * Duplicate change files for beta release * add show label in default view always * fix lint * fix build * fix cc * Update packages/react-composites CallWithChatComposite browser test snapshots * rebuild API * Update packages/react-composites CallComposite browser test snapshots * fix double large button * update cc * build API * Update packages/react-composites CallComposite browser test snapshots * Add test * add auto dismiss on selection * Change files * Duplicate change files for beta release * remove test.only * Update packages/react-composites CallComposite browser test snapshots * add focused content to mobile * add icons representing selected mode * disable for hold screen * update test to have video people * remove test.only * add test to see menu options in bottom sheet * remove test.only * fix cc * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Gallery layouts] Update storybook for gallery layouts (#3616) * update storybook for gallery layouts * Change files * Duplicate change files for beta release * Update packages/storybook/stories/VideoGallery/VideoGallery.stories.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Update packages/storybook/stories/CallComposite/CallCompositeDocs.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * add missing layout to storybook controls * fix prettier * videogallery QOL improvements * move layout state to composite * track overflow gallery position in composite * fix build * large gallery fixes --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> * [Gallery Layouts] Update composite options and icons for public preview (#3637) * update CC for beta release * Change files * Duplicate change files for beta release * Fix mobile drawer * Update packages/react-composites CallWithChatComposite browser test snapshots * fix strings * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * tag survey * remove on render avatar from composites * remove on render avatar from composites * remove on render avatar from composites --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Co-authored-by: alkwa-msft <79329532+alkwa-msft@users.noreply.github.com> Co-authored-by: prabhjot-msft <97124699+prabhjot-msft@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> * [Gallery layouts] stableize gallery layouts (#3665) * stable ize gallery layouts * Change files * Duplicate change files for beta release * update api files * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Merge Prerelease 1.9.0 beta.1 back to Main (#3669) * beta-release-minor version bump * Collect CHANGELOG * Beta 1.9.0-beta.1 Changelog Grooming (#3648) * Create groom me file for groom changelog branch * Update CHANGELOG.beta.md to include public preview features Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Update CHANGELOG.beta.md with grooming changes Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Update CHANGELOG.beta.md groom bugs Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Update CHANGELOG.beta.md more bug gooming Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Delete GROOMME.md Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Update CHANGELOG.beta.md combine communication stable and beta updates to one entry Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Update CHANGELOG.beta.md Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> --------- Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Change files * Duplicate change files for beta release --------- Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Package updates] Common, Calling, Chat updates (#3634) * Update stable common deps * Change files * Duplicate change files for beta release * fix build issues new package * Calling SDK updates * update locks * update beta * add rush common versions * remove casting * remove unused import * add new calling types from SDK * [Chat] Menu button accessibility fix (#3672) * Removed workaround for mouseDown event in jest tests (#3673) * [Chat]Update image padding for ImageGallery (#3651) * Update image padding for ImageGallery * Change files * Duplicate change files for beta release * Update packages/react-composites ChatComposite browser test snapshots * [Dependency updates] calling bindings fix (#3674) * fix component bindings * fix start call in adapter for new id * Change files * Duplicate change files for beta release * remove the console log * update API files --------- Co-authored-by: alkwa-msft <79329532+alkwa-msft@users.noreply.github.com> * [Bug Fix] Fix issue where Call with Chat adapter would create multiple clients (#3676) * remove old logic for open in other tab * fix cwc adapter hook multi create * Change files * Duplicate change files for beta release * remove commented code * remove commented code * [Dependabot] update webpack (#3667) * update webpack * Change files * Duplicate change files for beta release * create lock files * [Bugfix] Fix issue where bottom sheet was not selecting first item (#3678) * Fix focus on each subMenu * Change files * Duplicate change files for beta release * build API files * update stable * rename per nit * [Chat] Error message update for edit message component (#3680) * Update communication calling dependency (#3682) * update calling * Change files * Duplicate change files for beta release * [A11y bugfix] Focus picker when gallery effects are open (#3681) * make picker options buttons * add stack for spacing * remove commented code * add ref to sidepane to camera button [Broken] * remove ref and create hook * remove prop * Change files * Duplicate change files for beta release * build API * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Storybook] Update setup pages (#3658) * update adapters page wording * update quickstarts for stable setup * Change files * Duplicate change files for beta release * fix lint --------- Co-authored-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * survey * star; * star survey * star survey * star survey * star survey * star survey * star survey * star survey * tag survey * [Chat] Removed bottom paddings for the edit message buttons (#3683) * [bugfix] calling version fix (#3685) * update entry point to latest calling beta * Change files * Duplicate change files for beta release * [Dependency Update] Rush -> 5.109.1 (#3687) * [Dependency Updates] Merge updates from v2 branch (part 1) (#3690) * Update backward-compatible packages * Update api-extractor and api-documentor * Alkwa/remove captions icon fade in (#3688) * adding in fluent prop to not fade in the persona * Change files * adding changelog entry * Merge Prerelease stable minor/1.9.0 into main (#3666) * stable-minor version bump * Collect CHANGELOG * Groom changelog for 1.9.0 stable release (#3664) * Create groom me file for groom changelog branch * Groom changelog for 1.9.0 stable release * Change files * Duplicate change files for beta release --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Bump package versions to beta.0 for next release --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * latest api * Update .babelrc.js Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> * linter; * Latest API for end of call survey (#3693) * survey * star; * star survey * Change files * Duplicate change files for beta release * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey * star survey * tag survey * tag survey * tag survey * tag survey * tag survey * tag survey * tag survey * tag survey * tag survey * latest api * build file * linter * api * api --------- Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> * composite changes * changes * update pr --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Co-authored-by: prabhjot-msft <97124699+prabhjot-msft@users.noreply.github.com> Co-authored-by: alkwa-msft <79329532+alkwa-msft@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> Co-authored-by: Emlyn Bolton <3941071+emlynmac@users.noreply.github.com> Co-authored-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> Co-authored-by: John <109105353+jpeng-ms@users.noreply.github.com> --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Co-authored-by: prabhjot-msft <97124699+prabhjot-msft@users.noreply.github.com> Co-authored-by: alkwa-msft <79329532+alkwa-msft@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> Co-authored-by: Emlyn Bolton <3941071+emlynmac@users.noreply.github.com> Co-authored-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> Co-authored-by: John <109105353+jpeng-ms@users.noreply.github.com> * update pr * update pr * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * update * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Emlyn Bolton <3941071+emlynmac@users.noreply.github.com> Co-authored-by: alkwa-msft <79329532+alkwa-msft@users.noreply.github.com> Co-authored-by: prabhjot-msft <97124699+prabhjot-msft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> Co-authored-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> Co-authored-by: John <109105353+jpeng-ms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Star Survey inside call composite
Why
End of call survey
How Tested
Tested with samples
Process & policy checklist
Is this a breaking change?