Skip to content

[A11y bugfix] EndCall button high contrast appearence#3905

Merged
dmceachernmsft merged 17 commits intomainfrom
dmceachernmsft/end-call-HC-fix
Dec 18, 2023
Merged

[A11y bugfix] EndCall button high contrast appearence#3905
dmceachernmsft merged 17 commits intomainfrom
dmceachernmsft/end-call-HC-fix

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft commented Dec 12, 2023

What

Updates the Endcall button to respect the different end call appearances expected for high contrast modes

also fixes configuration text to respect the colors when dealing with high contrast

Why

Improves visibility of the end call button for visually impaired users

https://skype.visualstudio.com/SPOOL/_workitems/edit/3261836

How Tested

image
image
image
Tested locally

@dmceachernmsft dmceachernmsft requested review from a team as code owners December 12, 2023 21:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 12, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-jmfmbnjnts.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 12, 2023 •
edited
Loading

Calling bundle size is increased❗.

  • Current size: 5612692
  • Base size: 5612370
  • Diff size: 322

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 12, 2023 •
edited
Loading

Chat bundle size is not changed.

  • Current size: 1533818
  • Base size: 1533818
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 12, 2023 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 6432607
  • Base size: 6432285
  • Diff size: 322

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 13, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-dobvpxdwmy.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 13, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-cncuoilvac.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-aerxgbizxp.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Dec 14, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Dec 14, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-qqocxfbral.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-yxhzqtpzfe.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 15, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-kcrflhrjth.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ivssqkzqqe.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-eomqecfyqy.chromatic.com/

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) December 18, 2023 17:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-qztchzekcz.chromatic.com/

@dmceachernmsft dmceachernmsft merged commit bf35fda into main Dec 18, 2023
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/end-call-HC-fix branch December 18, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@edwardlee-msft edwardlee-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmceachernmsft @JamesBurnside @edwardlee-msft
⚡