Skip to content

[A11y bugfix] EndCall button high contrast appearence #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmceachernmsft merged 17 commits into from
Dec 18, 2023
Merged

[A11y bugfix] EndCall button high contrast appearence #3905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ece814a
update end call css per A11y
dmceachernmsft Dec 12, 2023
e957de7
Change files
dmceachernmsft Dec 12, 2023
7830ece
Duplicate change files for beta release
dmceachernmsft Dec 12, 2023
b10342c
adjust css for Configuration title to also respect the a11y colors
dmceachernmsft Dec 12, 2023
19635db
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] Dec 13, 2023
2c1c579
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] Dec 13, 2023
dd531fd
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] Dec 13, 2023
d0ad0f6
Merge branch 'dmceachernmsft/end-call-HC-fix' of https://github.com/A…
github-actions[bot] Dec 13, 2023
6e28748
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 14, 2023
3c43ff0
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 14, 2023
6ee3e28
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] Dec 14, 2023
f4cbdd6
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 14, 2023
e664fe1
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 14, 2023
b949130
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 15, 2023
413d657
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 18, 2023
4dc11ca
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 18, 2023
e001da0
Merge branch 'main' into dmceachernmsft/end-call-HC-fix
dmceachernmsft Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-f80c75bf-fb46-47c0-a858-9f998796ceec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "A11y",
"comment": "Update EndCall button appearence to match high contrast expectations on windows",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-f80c75bf-fb46-47c0-a858-9f998796ceec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "A11y",
"comment": "Update EndCall button appearence to match high contrast expectations on windows",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
14 changes: 8 additions & 6 deletions packages/react-components/src/components/EndCallButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,22 +80,23 @@ const darkThemeCallButtonStyles = {
color: darkTheme.callingPalette.iconWhite,
background: darkTheme.callingPalette.callRed,
'@media (forced-colors: active)': {
forcedColorAdjust: 'none'
forcedColorAdjust: 'auto',
border: `1px ${lightTheme.palette?.neutralQuaternaryAlt} solid`
},
':focus::after': { outlineColor: `${darkTheme.callingPalette.iconWhite} !important` } // added !important to avoid override by FluentUI button styles
},
rootHovered: {
color: darkTheme.callingPalette.iconWhite,
background: darkTheme.callingPalette.callRed,
'@media (forced-colors: active)': {
forcedColorAdjust: 'none'
forcedColorAdjust: 'auto'
}
},
rootPressed: {
color: darkTheme.callingPalette.iconWhite,
background: darkTheme.callingPalette.callRed,
'@media (forced-colors: active)': {
forcedColorAdjust: 'none'
forcedColorAdjust: 'auto'
}
},
label: {
Expand All @@ -108,22 +109,23 @@ const lightThemeCallButtonStyles = {
color: lightTheme.callingPalette.iconWhite,
background: lightTheme.callingPalette.callRed,
'@media (forced-colors: active)': {
forcedColorAdjust: 'none'
forcedColorAdjust: 'auto',
border: `1px ${lightTheme.palette?.neutralQuaternaryAlt} solid`
},
':focus::after': { outlineColor: `${lightTheme.callingPalette.iconWhite} !important` } // added !important to avoid override by FluentUI button styles
},
rootHovered: {
color: lightTheme.callingPalette.iconWhite,
background: lightTheme.callingPalette.callRed,
'@media (forced-colors: active)': {
forcedColorAdjust: 'none'
forcedColorAdjust: 'auto'
}
},
rootPressed: {
color: lightTheme.callingPalette.iconWhite,
background: lightTheme.callingPalette.callRed,
'@media (forced-colors: active)': {
forcedColorAdjust: 'none'
forcedColorAdjust: 'auto'
}
},
label: {
Expand Down
6 changes: 6 additions & 0 deletions packages/react-composites/src/composites/CallComposite/styles/CallConfiguration.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ const configurationPageTextDecoration = (theme: ITheme): IStyle => {
strokeWidth: _pxToRem(1.5),
text: {
letterSpacing: '-0.02rem' // cope with extra width due to stroke width
},
'@media (forced-colors: active)': {
forcedColorAdjust: 'auto',
fill: theme.palette.neutralQuaternaryAlt,
textShadow: 'none',
stroke: 'none'
}
};
};
Expand Down
⚡