Skip to content

Avoid permissions API on Android WebView#5888

Merged
JamesBurnside merged 6 commits intomainfrom
jaburnsi/fix-android-webview
Jun 10, 2025
Merged

Avoid permissions API on Android WebView#5888
JamesBurnside merged 6 commits intomainfrom
jaburnsi/fix-android-webview

Conversation

@JamesBurnside
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside commented Jun 9, 2025

What

  • In Stateful layer, if the calling SDK says granted, use the SDK value (avoiding permissions API badness on Android WebView)
  • In Composite layer, do a explicit check for Android WebView to avoid permissions API usage there
  • Improve some memoization on the config page
  • Add local storage check as that is not available on android webview

Why

Fix #5875

How Tested

Locally in Android web view.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29587 / 47220
62.65%
29587 / 47220
62.65%
816 / 1492
54.69%
2428 / 3851
63.04%
Current 29582 / 47224
62.64%
29582 / 47224
62.64%
816 / 1492
54.69%
2442 / 3861
63.24%
Diff -5 / 4
-0.01%
-5 / 4
-0.01%
0 / 0
0%
14 / 10
0.2%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58376 / 94711
61.63%
58376 / 94711
61.63%
1187 / 2715
43.72%
3420 / 5793
59.03%
Current 58375 / 94755
61.6%
58375 / 94755
61.6%
1187 / 2716
43.7%
3388 / 5776
58.65%
Diff -1 / 44
-0.03%
-1 / 44
-0.03%
0 / 1
-0.02%
-32 / -17
-0.38%

return option.disabled;
};

/* @conditional-compile-remove(call-readiness) */
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I wonder if this method makes sense to have in the common/utils.tsx

@JamesBurnside JamesBurnside enabled auto-merge (squash) June 10, 2025 17:01
@github-actions
Copy link
Copy Markdown
Contributor

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 5823986 5824455 ⚠️ increased 469
398.bundle.js 12413560 12413560 ➖ unchanged 0

Total change: +469 B ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6799521 6799990 ⚠️ increased 469
350.bundle.js 362425 362425 ➖ unchanged 0
398.bundle.js 12413574 12413574 ➖ unchanged 0
450.bundle.js 4471 4471 ➖ unchanged 0
82.bundle.js 28323 28323 ➖ unchanged 0
91.bundle.js 4071 4071 ➖ unchanged 0

Total change: +469 B ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1778662 1778807 ⚠️ increased 145
195.bundle.js 365693 365693 ➖ unchanged 0
450.bundle.js 4455 4455 ➖ unchanged 0
82.bundle.js 28307 28307 ➖ unchanged 0
91.bundle.js 4055 4055 ➖ unchanged 0

Total change: +145 B ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

@JamesBurnside JamesBurnside merged commit 348879b into main Jun 10, 2025
41 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/fix-android-webview branch June 10, 2025 17:15
prabhjot-msft added a commit that referenced this pull request Jun 17, 2025
Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to access camera inside webview when using call composite

4 participants