Avoid permissions API on Android WebView#5888
Merged
JamesBurnside merged 6 commits intomainfrom Jun 10, 2025
Merged
Conversation
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dpgtrnmqls.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fkilrqudfs.chromatic.com/ |
dmceachernmsft
approved these changes
Jun 9, 2025
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bmbinubkbc.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
JoshuaLai
reviewed
Jun 10, 2025
| return option.disabled; | ||
| }; | ||
|
|
||
| /* @conditional-compile-remove(call-readiness) */ |
Member
There was a problem hiding this comment.
nit: I wonder if this method makes sense to have in the common/utils.tsx
JoshuaLai
approved these changes
Jun 10, 2025
Contributor
📦 Calling bundle size
Total change: +469 B |
Contributor
📦 CallWithChat bundle size
Total change: +469 B |
Contributor
📦 Chat bundle size
Total change: +145 B |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vlonugzvhh.chromatic.com/ |
prabhjot-msft
pushed a commit
that referenced
this pull request
Jun 17, 2025
prabhjot-msft
added a commit
that referenced
this pull request
Jun 17, 2025
JamesBurnside
added a commit
that referenced
this pull request
Jun 18, 2025
JamesBurnside
added a commit
that referenced
this pull request
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #5875
How Tested
Locally in Android web view.