Avoid permissions API on Android WebView #5908
Merged
prabhjot-msft merged 1 commit intorelease/1.28.0-beta.2from Jun 17, 2025
Merged
Avoid permissions API on Android WebView #5908prabhjot-msft merged 1 commit intorelease/1.28.0-beta.2from
prabhjot-msft merged 1 commit intorelease/1.28.0-beta.2from
Conversation
prabhjot-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
vhuseinova-msft and
waynemo
and removed request for
a team
JamesBurnside
approved these changes
Jun 17, 2025
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-sqiqmeimhy.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In Stateful layer, if the calling SDK says granted, use the SDK value (avoiding permissions API badness on Android WebView)
In Composite layer, do a explicit check for Android WebView to avoid permissions API usage there
Improve some memoization on the config page
Add local storage check as that is not available on android webview
Why
How Tested
Process & policy checklist
Is this a breaking change?