Add AKS Private FQDN output#112
Conversation
|
Good day, this is the first PR. do point me to right direction should I miss out anything. The changes is intend to output Private FQDN, to be used by subsequent Private DNS link actions for Hub and Spoke network topology linkage. Kindly review and approve it. |
|
MAIN BRANCH PUSH DETECTED DUE TO #241, THIS PR WILL BE UPDATED. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
Thanks @joesoh2021 for opening and updating this pr! Now we've added a CI pipeline to this repo, would you please read Pre-Commit & Pr-Check & Test section in readme file to make this pr meets our new pr requirements? You can leave the e2e-test to the pipeline. Thanks for your understanding, have a nice day. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #230, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
1 similar comment
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #253, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #249, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
@lonegunmanb can we close this PR without merging, in favour of #251 ? |
|
MAIN BRANCH PUSH DETECTED DUE TO #245, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
1 similar comment
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #259, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #262, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #260, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #251, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
Thanks @joesoh2021 for open this pr and apology for this crazy late reply, we've brought so many changes to this module so I've submitted and merged a new pr #251 for this feature. Now I'm closing this pr since we've already added this feature, thanks for your contribution. |
3 participants
Fixes #000
Changes proposed in the pull request: