add aci_connector addon#230
Merged
lonegunmanb merged 1 commit intoAzure:masterfrom Sep 14, 2022
Merged
Conversation
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #241, THIS PR WILL BE UPDATED. |
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED. |
1 similar comment
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED. |
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
Member
|
Hi @zioproto , I'd like to review this pr since now we have CI pipeline, would you please solve the conflict? Thanks！ |
zioproto
force-pushed
the
aci_connector_linux
branch
from
60e3663 to
15836de
Compare
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
zioproto
force-pushed
the
aci_connector_linux
branch
from
15836de to
73f06ab
Compare
Contributor
Author
|
@lonegunmanb all tests are passing, I believe this one is ready to merge. thanks |
Closed
This was referenced Sep 14, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor of pr #130 on the new version of the module.