Skip to content

Possibility to setup multiple node pools#212

Closed
Sanverik wants to merge 2 commits intoAzure:masterfrom
Sanverik:node-pools
Closed

Possibility to setup multiple node pools#212
Sanverik wants to merge 2 commits intoAzure:masterfrom
Sanverik:node-pools

Conversation

@Sanverik
Copy link
Copy Markdown

@Sanverik Sanverik commented Jul 6, 2022

Changes proposed in the pull request:

  • extend functionality to be able to specify multiple node pools within the module

@ghost
Copy link
Copy Markdown

ghost commented Jul 6, 2022

CLA assistant check
All CLA requirements met.

@lonegunmanb
Copy link
Copy Markdown
Member

Thanks @Sanverik for opening this PR! My personal opinion this module will focus on Aks cluster itself. The caller might attach multiple node pools with different configurations to one Aks cluster so I prefer a standalone module for the node pool.

@nlamirault
Copy link
Copy Markdown
Contributor

@lonegunmanb @Sanverik what about transform this PR using a submodule of the AKS module ?

@Sanverik
Copy link
Copy Markdown
Author

@nlamirault I don't see any reason to create additional module for a wrapper around one resource (like AKS module already is)

@Sanverik
Copy link
Copy Markdown
Author

For me it looks natural to have an option to specify multiple node pool within AKS module by using my way of doing it

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #241, THIS PR WILL BE UPDATED.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@Azure Azure deleted a comment from github-actions Bot Sep 13, 2022
@Azure Azure deleted a comment from github-actions Bot Sep 13, 2022
@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #230, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #253, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #249, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #245, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb
Copy link
Copy Markdown
Member

@Sanverik Thanks for opening this pr, I'm closing it because I'd like to keep this module focused on Kubernetes cluster itself.

@lonegunmanb lonegunmanb reopened this Mar 8, 2023
@lonegunmanb lonegunmanb modified the milestones: 7.0.0, 6.8.0 Mar 8, 2023
@lonegunmanb lonegunmanb closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants